Re: [libvirt] [PATCH] configure: Fix check for --with-login-shell on Windows

2016-04-11 Thread Andrea Bolognani
On Fri, 2016-04-08 at 13:50 -0400, Cole Robinson wrote: > On 04/08/2016 10:55 AM, Andrea Bolognani wrote: > > > > The check is supposed to stop users from trying to compile > > virt-login-shell on Windows by erroring out during the > > configure phase; however, there are two flaws in it: > > > >

Re: [libvirt] [PATCH] configure: Fix check for --with-login-shell on Windows

2016-04-08 Thread Cole Robinson
On 04/08/2016 10:55 AM, Andrea Bolognani wrote: > The check is supposed to stop users from trying to compile > virt-login-shell on Windows by erroring out during the > configure phase; however, there are two flaws in it: > > * the value of "x$with_win" is compared to "yes" instead > of "xyes

[libvirt] [PATCH] configure: Fix check for --with-login-shell on Windows

2016-04-08 Thread Andrea Bolognani
The check is supposed to stop users from trying to compile virt-login-shell on Windows by erroring out during the configure phase; however, there are two flaws in it: * the value of "x$with_win" is compared to "yes" instead of "xyes" (note the "x" in the first string) * "test" is not bein