Re: [libvirt] [PATCH] consolidate virXPathNodeSet()

2009-10-22 Thread Daniel Veillard
On Wed, Oct 21, 2009 at 07:51:45PM +0100, Daniel P. Berrange wrote: On Wed, Oct 21, 2009 at 05:24:03PM +0200, Daniel Veillard wrote: While reviewing Rich last patch I was afraid that virXPathNodeSet() could return -1 when doing an evaluation failure. It is based on xmlXPathEval() from

[libvirt] [PATCH] consolidate virXPathNodeSet()

2009-10-21 Thread Daniel Veillard
While reviewing Rich last patch I was afraid that virXPathNodeSet() could return -1 when doing an evaluation failure. It is based on xmlXPathEval() from libxml2 whose behaviour is to possibly return NULL on XPath evaluation failure independantly of the kind of failure:

Re: [libvirt] [PATCH] consolidate virXPathNodeSet()

2009-10-21 Thread Daniel P. Berrange
On Wed, Oct 21, 2009 at 05:24:03PM +0200, Daniel Veillard wrote: While reviewing Rich last patch I was afraid that virXPathNodeSet() could return -1 when doing an evaluation failure. It is based on xmlXPathEval() from libxml2 whose behaviour is to possibly return NULL on XPath evaluation