Re: [libvirt] [PATCH] cpuCompare: Fix comparison of two host CPUs

2010-07-13 Thread Dan Kenigsberg
On Tue, Jul 13, 2010 at 11:14:13AM +0100, Daniel P. Berrange wrote: > On Tue, Jul 13, 2010 at 12:03:43PM +0200, Jiri Denemark wrote: > > Hi Dan, > > > > > I do not compare CPUs for fun, but rather to know if a guest can be run > > > on a specific host. However, this is not exactly what > > > virCo

Re: [libvirt] [PATCH] cpuCompare: Fix comparison of two host CPUs

2010-07-13 Thread Daniel P. Berrange
On Tue, Jul 13, 2010 at 12:03:43PM +0200, Jiri Denemark wrote: > Hi Dan, > > > I do not compare CPUs for fun, but rather to know if a guest can be run > > on a specific host. However, this is not exactly what > > virConnectCompareCPU gives me: A vmx-enabled host cpu is a superset of > > itself, bu

Re: [libvirt] [PATCH] cpuCompare: Fix comparison of two host CPUs

2010-07-13 Thread Jiri Denemark
Hi Dan, > I do not compare CPUs for fun, but rather to know if a guest can be run > on a specific host. However, this is not exactly what > virConnectCompareCPU gives me: A vmx-enabled host cpu is a superset of > itself, but it would not run itself as a guest since we do not have > nested vxm yet.

Re: [libvirt] [PATCH] cpuCompare: Fix comparison of two host CPUs

2010-07-12 Thread Dan Kenigsberg
Jiri, I have an unrelated concern regarding the semantics of comparison of host and guest CPUs. I do not compare CPUs for fun, but rather to know if a guest can be run on a specific host. However, this is not exactly what virConnectCompareCPU gives me: A vmx-enabled host cpu is a superset of itse

Re: [libvirt] [PATCH] cpuCompare: Fix comparison of two host CPUs

2010-07-12 Thread Jiri Denemark
> > When a CPU to be compared with host CPU describes a host CPU instead of > > a guest CPU, the result is incorrect. This is because instead of > > treating additional features in host CPU description as required, they > > were treated as if they were mentioned with all possible policies at the >

Re: [libvirt] [PATCH] cpuCompare: Fix comparison of two host CPUs

2010-07-12 Thread Daniel Veillard
On Mon, Jul 12, 2010 at 05:49:36PM +0200, Jiri Denemark wrote: > When a CPU to be compared with host CPU describes a host CPU instead of > a guest CPU, the result is incorrect. This is because instead of > treating additional features in host CPU description as required, they > were treated as if t

[libvirt] [PATCH] cpuCompare: Fix comparison of two host CPUs

2010-07-12 Thread Jiri Denemark
When a CPU to be compared with host CPU describes a host CPU instead of a guest CPU, the result is incorrect. This is because instead of treating additional features in host CPU description as required, they were treated as if they were mentioned with all possible policies at the same time. --- sr