On Fri, Apr 22, 2011 at 07:06:18PM +0200, Matthias Bolte wrote:
> I just took a look at it and the first instances are mostly const
> char* used for allocated strings. I didn't spot a real error yet.
Same here, looked at a dozen of these warnings, and just const char * being
used for allocated str
2011/4/22 Eric Blake :
> On 04/22/2011 10:31 AM, Christophe Fergeau wrote:
>> On Fri, Apr 22, 2011 at 10:17:01AM -0600, Eric Blake wrote:
>>> On 04/22/2011 10:11 AM, Matthias Bolte wrote:
remoteDispatchError(rerr);
- VIR_FREE(ret->names.names_len);
+ VIR_FREE(r
2011/4/22 Eric Blake :
> On 04/22/2011 10:11 AM, Matthias Bolte wrote:
>> ---
>> daemon/remote.c | 8
>> 1 files changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/daemon/remote.c b/daemon/remote.c
>> index 54fef64..1c98bba 100644
>> --- a/daemon/remote.c
>> +++ b/daemon/remot
On Fri, Apr 22, 2011 at 10:55:04AM -0600, Eric Blake wrote:
> On 04/22/2011 10:31 AM, Christophe Fergeau wrote:
> > -# define VIR_FREE(ptr) virFree(&(ptr))
> > +# define VIR_FREE(ptr) \
> > +do { void *check_type = (ptr); virFree(&(check_type)); } while (0)
>
> Not quite. That assigns check_t
On 04/22/2011 10:31 AM, Christophe Fergeau wrote:
> On Fri, Apr 22, 2011 at 10:17:01AM -0600, Eric Blake wrote:
>> On 04/22/2011 10:11 AM, Matthias Bolte wrote:
>>> remoteDispatchError(rerr);
>>> -VIR_FREE(ret->names.names_len);
>>> +VIR_FREE(ret->names.names_val);
>>
>> An
On Fri, Apr 22, 2011 at 10:17:01AM -0600, Eric Blake wrote:
> On 04/22/2011 10:11 AM, Matthias Bolte wrote:
> > remoteDispatchError(rerr);
> > -VIR_FREE(ret->names.names_len);
> > +VIR_FREE(ret->names.names_val);
>
> And to think I missed those in the huge patch. Oops.
M
On 04/22/2011 10:11 AM, Matthias Bolte wrote:
> ---
> daemon/remote.c |8
> 1 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/daemon/remote.c b/daemon/remote.c
> index 54fef64..1c98bba 100644
> --- a/daemon/remote.c
> +++ b/daemon/remote.c
> @@ -3681,7 +3681,7 @@ remo
---
daemon/remote.c |8
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/daemon/remote.c b/daemon/remote.c
index 54fef64..1c98bba 100644
--- a/daemon/remote.c
+++ b/daemon/remote.c
@@ -3681,7 +3681,7 @@ remoteDispatchListNetworks(struct qemud_server *server
ATTRIBUTE_UN
