[libvirt] [PATCH] daemon: exclude requirement for probes.h on systems without systemtap

2010-10-22 Thread Justin Clift
This 1-liner was actually written by Eric Blake, over IRC. It addresses a compilation failure in make dist and make rpm for systems without the dtrace/systemtap development libraries installed. --- daemon/Makefile.am |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git

Re: [libvirt] [PATCH] daemon: exclude requirement for probes.h on systems without systemtap

2010-10-22 Thread Eric Blake
On 10/22/2010 02:57 PM, Justin Clift wrote: This 1-liner was actually written by Eric Blake, over IRC. It addresses a compilation failure in make dist and make rpm for systems without the dtrace/systemtap development libraries installed. --- daemon/Makefile.am |2 +- 1 files changed, 1

Re: [libvirt] [PATCH] daemon: exclude requirement for probes.h on systems without systemtap

2010-10-22 Thread Justin Clift
On 10/23/2010 08:05 AM, Eric Blake wrote: snip if WITH_DTRACE libvirtd_LDADD += probes.o -libvirtd_SOURCES += probes.h +libvirtd_nodist_SOURCES = probes.h Given your testing of my one-liner IRC comment: ACK. Thanks. Pushed. :) -- libvir-list mailing list libvir-list@redhat.com

Re: [libvirt] [PATCH] daemon: exclude requirement for probes.h on systems without systemtap

2010-10-22 Thread Eric Blake
On 10/22/2010 03:05 PM, Eric Blake wrote: On 10/22/2010 02:57 PM, Justin Clift wrote: This 1-liner was actually written by Eric Blake, over IRC. It addresses a compilation failure in make dist and make rpm for systems without the dtrace/systemtap development libraries installed. ---

Re: [libvirt] [PATCH] daemon: exclude requirement for probes.h on systems without systemtap

2010-10-22 Thread Justin Clift
On 10/23/2010 08:52 AM, Eric Blake wrote: snip Given your testing of my one-liner IRC comment: ACK. Actually, the automake manual says this needs to be nodist_libvirtd_SOURCES (sorry I didn't check the manual before ACK'ing; and I'm assuming you tested without dtrace). Just pushed the