Re: [libvirt] [PATCH] docs: document requirement to provide Signed-off-by lines for DCO

2018-01-25 Thread Kashyap Chamarthy
On Mon, Jan 22, 2018 at 12:40:37PM +, Daniel P. Berrange wrote: > Document that contributors are required to assert compliance with the > Developers Certification of Origin 1.1, by providing Signed-off-by tags > for all commit messages. The DCO is formally stating what we have long >

Re: [libvirt] [PATCH] docs: document requirement to provide Signed-off-by lines for DCO

2018-01-24 Thread Daniel P. Berrange
On Wed, Jan 24, 2018 at 04:14:54PM +0100, Jiri Denemark wrote: > pushed. In other words, having Reviewed-by in the commit message is nice > for generating statistics for KVM Forum keynotes, once the patch gets > out of our git repository (i.e., is backported to a downstream), or when BTW, when

Re: [libvirt] [PATCH] docs: document requirement to provide Signed-off-by lines for DCO

2018-01-24 Thread Jiri Denemark
On Wed, Jan 24, 2018 at 14:34:49 +, Daniel P. Berrange wrote: ... > I had considered whether we should require a Reviewed-by tags to show > that someone other than the author has reviewed a patch before it is > pushed. It is not practical to check this automatically though, given > that we

Re: [libvirt] [PATCH] docs: document requirement to provide Signed-off-by lines for DCO

2018-01-24 Thread Daniel P. Berrange
On Wed, Jan 24, 2018 at 02:59:17PM +0100, Ján Tomko wrote: > > > + a "Signed-off-by" line to every commit message. The presence > > "line containing the contributor's name and e-mail" maybe? > I presume just 'Signed-off-by' is not enough for the "legal snake oil", > even though it's all

Re: [libvirt] [PATCH] docs: document requirement to provide Signed-off-by lines for DCO

2018-01-24 Thread Ján Tomko
On Mon, Jan 22, 2018 at 02:28:14PM +0100, Andrea Bolognani wrote: On Mon, 2018-01-22 at 12:40 +, Daniel P. Berrange wrote: Document that contributors are required to assert compliance with the Developers Certification of Origin 1.1, by providing Signed-off-by tags Both here... for all

Re: [libvirt] [PATCH] docs: document requirement to provide Signed-off-by lines for DCO

2018-01-22 Thread Andrea Bolognani
On Mon, 2018-01-22 at 12:40 +, Daniel P. Berrange wrote: > Document that contributors are required to assert compliance with the > Developers Certification of Origin 1.1, by providing Signed-off-by tags Both here... > for all commit messages. The DCO is formally stating what we have long >

[libvirt] [PATCH] docs: document requirement to provide Signed-off-by lines for DCO

2018-01-22 Thread Daniel P. Berrange
Document that contributors are required to assert compliance with the Developers Certification of Origin 1.1, by providing Signed-off-by tags for all commit messages. The DCO is formally stating what we have long implicitly expected of contributors in terms of their legal rights to make the