Re: [libvirt] [PATCH] docs: formatdomain: Specify the default value of 'check' attribute

2018-01-10 Thread Kashyap Chamarthy
On Wed, Jan 10, 2018 at 11:17:21AM +0100, Jiri Denemark wrote: > On Wed, Jan 10, 2018 at 11:03:20 +0100, Kashyap Chamarthy wrote: [...] > > I just double-confirmed with the admin, this was what happened: > > > > - They were running QEMU 2.6.5, VMs were starting fine. > > > > - Once they upg

Re: [libvirt] [PATCH] docs: formatdomain: Specify the default value of 'check' attribute

2018-01-10 Thread Jiri Denemark
On Wed, Jan 10, 2018 at 11:13:28 +0100, Kashyap Chamarthy wrote: > On Wed, Jan 10, 2018 at 09:51:19AM +0100, Pavel Hrdina wrote: > > On Tue, Jan 09, 2018 at 08:28:20PM +0100, Jiri Denemark wrote: > > > On Tue, Jan 09, 2018 at 19:44:18 +0100, Kashyap Chamarthy wrote: > > > > On Tue, Jan 09, 2018 at

Re: [libvirt] [PATCH] docs: formatdomain: Specify the default value of 'check' attribute

2018-01-10 Thread Jiri Denemark
On Wed, Jan 10, 2018 at 11:03:20 +0100, Kashyap Chamarthy wrote: > On Tue, Jan 09, 2018 at 08:28:20PM +0100, Jiri Denemark wrote: > > On Tue, Jan 09, 2018 at 19:44:18 +0100, Kashyap Chamarthy wrote: ... > > > So "somehow" QEMU added the CPU features 'vme' and 'arat' by itself, now > > > you have to

Re: [libvirt] [PATCH] docs: formatdomain: Specify the default value of 'check' attribute

2018-01-10 Thread Kashyap Chamarthy
On Wed, Jan 10, 2018 at 09:51:19AM +0100, Pavel Hrdina wrote: > On Tue, Jan 09, 2018 at 08:28:20PM +0100, Jiri Denemark wrote: > > On Tue, Jan 09, 2018 at 19:44:18 +0100, Kashyap Chamarthy wrote: > > > On Tue, Jan 09, 2018 at 04:37:10PM +0100, Jiri Denemark wrote: [...] > One additional note for

Re: [libvirt] [PATCH] docs: formatdomain: Specify the default value of 'check' attribute

2018-01-10 Thread Kashyap Chamarthy
On Tue, Jan 09, 2018 at 08:28:20PM +0100, Jiri Denemark wrote: > On Tue, Jan 09, 2018 at 19:44:18 +0100, Kashyap Chamarthy wrote: [...] > I'm not saying there's nothing to be clarified. Just that explicitly > specifying the default value will not help at all since it's complicated > and confusing

Re: [libvirt] [PATCH] docs: formatdomain: Specify the default value of 'check' attribute

2018-01-10 Thread Pavel Hrdina
On Tue, Jan 09, 2018 at 08:28:20PM +0100, Jiri Denemark wrote: > On Tue, Jan 09, 2018 at 19:44:18 +0100, Kashyap Chamarthy wrote: > > On Tue, Jan 09, 2018 at 04:37:10PM +0100, Jiri Denemark wrote: > > > On Tue, Jan 09, 2018 at 15:32:54 +0100, Kashyap Chamarthy wrote: > > > > [...] > > > > > > But

Re: [libvirt] [PATCH] docs: formatdomain: Specify the default value of 'check' attribute

2018-01-09 Thread Jiri Denemark
On Tue, Jan 09, 2018 at 19:44:18 +0100, Kashyap Chamarthy wrote: > On Tue, Jan 09, 2018 at 04:37:10PM +0100, Jiri Denemark wrote: > > On Tue, Jan 09, 2018 at 15:32:54 +0100, Kashyap Chamarthy wrote: > > [...] > > > > But doesn't tell *what* the default value is. It is check='partial'. > > > Ment

Re: [libvirt] [PATCH] docs: formatdomain: Specify the default value of 'check' attribute

2018-01-09 Thread Kashyap Chamarthy
On Tue, Jan 09, 2018 at 04:37:10PM +0100, Jiri Denemark wrote: > On Tue, Jan 09, 2018 at 15:32:54 +0100, Kashyap Chamarthy wrote: [...] > > But doesn't tell *what* the default value is. It is check='partial'. > > Mention it so. [...] > NACK > > As I said on IRC, the default differs with guest

Re: [libvirt] [PATCH] docs: formatdomain: Specify the default value of 'check' attribute

2018-01-09 Thread Jiri Denemark
On Tue, Jan 09, 2018 at 15:32:54 +0100, Kashyap Chamarthy wrote: > The 'check' attribute is referring to this: > > > > Upstream documentation says, it is: > > used to request a specific way of checking whether the virtual CPU > matches the specification. It is usually safe to omit t

[libvirt] [PATCH] docs: formatdomain: Specify the default value of 'check' attribute

2018-01-09 Thread Kashyap Chamarthy
The 'check' attribute is referring to this: Upstream documentation says, it is: used to request a specific way of checking whether the virtual CPU matches the specification. It is usually safe to omit this attribute when starting a domain and stick with the default value. But d