Re: [libvirt] [PATCH] docs: more on qemu locking patterns

2011-02-02 Thread Eric Blake
On 02/02/2011 03:52 AM, Daniel P. Berrange wrote: > On Tue, Feb 01, 2011 at 05:37:10PM -0700, Eric Blake wrote: >> * src/qemu/THREADS.txt: Improve documentation. >> --- >> >>qemuDomainObjExitMonitor() >> -- Acquires the virDomainObjPtr lock >> - Releases the qemuMonitorObjPtr lock >> +

Re: [libvirt] [PATCH] docs: more on qemu locking patterns

2011-02-02 Thread Daniel P. Berrange
On Tue, Feb 01, 2011 at 05:37:10PM -0700, Eric Blake wrote: > * src/qemu/THREADS.txt: Improve documentation. > --- > > I'm trying to make sure we don't have any qemu locking gotchas, > given that I've had a bug report of a qemu monitor callback > being able to result in a domaing being unreference

[libvirt] [PATCH] docs: more on qemu locking patterns

2011-02-01 Thread Eric Blake
* src/qemu/THREADS.txt: Improve documentation. --- I'm trying to make sure we don't have any qemu locking gotchas, given that I've had a bug report of a qemu monitor callback being able to result in a domaing being unreferenced while in the middle of another command. As a first shot, I found that