Re: [libvirt] [PATCH] domain: Fix crash if trying to live update disk serial

2015-08-12 Thread Martin Kletzander
On Tue, Aug 11, 2015 at 05:37:30PM -0400, Cole Robinson wrote: On 08/11/2015 05:32 PM, John Ferlan wrote: On 08/11/2015 05:28 PM, Cole Robinson wrote: On 08/11/2015 05:25 PM, John Ferlan wrote: On 08/10/2015 07:33 PM, Cole Robinson wrote: If you pass diskserial XML to UpdateDevice, and

Re: [libvirt] [PATCH] domain: Fix crash if trying to live update disk serial

2015-08-11 Thread John Ferlan
On 08/10/2015 07:33 PM, Cole Robinson wrote: If you pass diskserial XML to UpdateDevice, and the original device didn't have a serial block, libvirtd crashes trying to read the original NULL serial string. Use _NULLABLE string comparisons to avoid the crash. A couple other properties

Re: [libvirt] [PATCH] domain: Fix crash if trying to live update disk serial

2015-08-11 Thread John Ferlan
On 08/11/2015 05:28 PM, Cole Robinson wrote: On 08/11/2015 05:25 PM, John Ferlan wrote: On 08/10/2015 07:33 PM, Cole Robinson wrote: If you pass diskserial XML to UpdateDevice, and the original device didn't have a serial block, libvirtd crashes trying to read the original NULL serial

Re: [libvirt] [PATCH] domain: Fix crash if trying to live update disk serial

2015-08-11 Thread Cole Robinson
On 08/11/2015 05:32 PM, John Ferlan wrote: On 08/11/2015 05:28 PM, Cole Robinson wrote: On 08/11/2015 05:25 PM, John Ferlan wrote: On 08/10/2015 07:33 PM, Cole Robinson wrote: If you pass diskserial XML to UpdateDevice, and the original device didn't have a serial block, libvirtd

Re: [libvirt] [PATCH] domain: Fix crash if trying to live update disk serial

2015-08-11 Thread Cole Robinson
On 08/11/2015 05:25 PM, John Ferlan wrote: On 08/10/2015 07:33 PM, Cole Robinson wrote: If you pass diskserial XML to UpdateDevice, and the original device didn't have a serial block, libvirtd crashes trying to read the original NULL serial string. Use _NULLABLE string comparisons to

[libvirt] [PATCH] domain: Fix crash if trying to live update disk serial

2015-08-10 Thread Cole Robinson
If you pass diskserial XML to UpdateDevice, and the original device didn't have a serial block, libvirtd crashes trying to read the original NULL serial string. Use _NULLABLE string comparisons to avoid the crash. A couple other properties needed the change too. --- src/conf/domain_conf.c | 8