Re: [libvirt] [PATCH] esx: Fix generator for string return values

2010-09-02 Thread Matthias Bolte
2010/9/1 Eric Blake ebl...@redhat.com: On 09/01/2010 09:32 AM, Matthias Bolte wrote: That's a bit tricky. In case Parameter.get_type_string() is called from Parameter.generate_return() then   string += %s*%s)%s % (self.get_type_string(), self.name, end_of_line) in line 104 adds the second

Re: [libvirt] [PATCH] esx: Fix generator for string return values

2010-09-01 Thread Matthias Bolte
2010/8/30 Eric Blake ebl...@redhat.com: On 08/29/2010 05:00 PM, Matthias Bolte wrote: Distinguish between strings as parameters (const char *) and strings as return values (char **). Here, you mention char**,          if self.type == String and \             self.occurrence not in

Re: [libvirt] [PATCH] esx: Fix generator for string return values

2010-09-01 Thread Eric Blake
On 09/01/2010 09:32 AM, Matthias Bolte wrote: That's a bit tricky. In case Parameter.get_type_string() is called from Parameter.generate_return() then string += %s*%s)%s % (self.get_type_string(), self.name, end_of_line) in line 104 adds the second *. I attached v2 where this is

Re: [libvirt] [PATCH] esx: Fix generator for string return values

2010-08-30 Thread Eric Blake
On 08/29/2010 05:00 PM, Matthias Bolte wrote: Distinguish between strings as parameters (const char *) and strings as return values (char **). Here, you mention char**, if self.type == String and \ self.occurrence not in [OCCURRENCE__REQUIRED_LIST,

[libvirt] [PATCH] esx: Fix generator for string return values

2010-08-29 Thread Matthias Bolte
Distinguish between strings as parameters (const char *) and strings as return values (char **). --- src/esx/esx_vi_generator.py | 19 +-- src/esx/esx_vi_methods.c| 22 -- 2 files changed, 25 insertions(+), 16 deletions(-) diff --git