Re: [libvirt] [PATCH] esx: Fix memory leak

2017-04-13 Thread John Ferlan
On 04/12/2017 06:06 AM, Wang King wrote: > Variable def going out of scope leaks the storage def.source.hosts points to. > --- > src/esx/esx_storage_backend_vmfs.c | 1 + > 1 file changed, 1 insertion(+) > ACK (and will push shortly) John -- libvir-list mailing list libvir-list@redhat.com ht

[libvirt] [PATCH] esx: Fix memory leak

2017-04-12 Thread Wang King
Variable def going out of scope leaks the storage def.source.hosts points to. --- src/esx/esx_storage_backend_vmfs.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/esx/esx_storage_backend_vmfs.c b/src/esx/esx_storage_backend_vmfs.c index a1a660b..940e5d1 100644 --- a/src/esx/esx_storage_

Re: [libvirt] [PATCH] esx: Fix memory leak in HostSystem managed object free function

2011-01-12 Thread Matthias Bolte
2011/1/11 Eric Blake : > On 01/11/2011 01:41 PM, Matthias Bolte wrote: >> --- >>  src/esx/esx_vi_types.c |    1 + >>  1 files changed, 1 insertions(+), 0 deletions(-) >> >> diff --git a/src/esx/esx_vi_types.c b/src/esx/esx_vi_types.c >> index 4ee4110..f3df2b5 100644 >> --- a/src/esx/esx_vi_types.c

Re: [libvirt] [PATCH] esx: Fix memory leak in HostSystem managed object free function

2011-01-11 Thread Eric Blake
On 01/11/2011 01:41 PM, Matthias Bolte wrote: > --- > src/esx/esx_vi_types.c |1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/src/esx/esx_vi_types.c b/src/esx/esx_vi_types.c > index 4ee4110..f3df2b5 100644 > --- a/src/esx/esx_vi_types.c > +++ b/src/esx/esx_vi_types.c

[libvirt] [PATCH] esx: Fix memory leak in HostSystem managed object free function

2011-01-11 Thread Matthias Bolte
--- src/esx/esx_vi_types.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/src/esx/esx_vi_types.c b/src/esx/esx_vi_types.c index 4ee4110..f3df2b5 100644 --- a/src/esx/esx_vi_types.c +++ b/src/esx/esx_vi_types.c @@ -1806,6 +1806,7 @@ ESX_VI__TEMPLATE__FREE(HostSystem,

Re: [libvirt] [PATCH] esx: Fix memory leak when looking up an non-existing domain by name

2010-08-17 Thread Matthias Bolte
2010/8/16 Eric Blake : > On 08/15/2010 12:34 PM, Matthias Bolte wrote: >>> such that you only have to have one label, instead of adding a new >>> label?  All three instances follow the same pattern. >>> >> >> Here's v2 attached. I also removed two already existing success labels. > > ACK to this ve

Re: [libvirt] [PATCH] esx: Fix memory leak when looking up an non-existing domain by name

2010-08-16 Thread Eric Blake
On 08/15/2010 12:34 PM, Matthias Bolte wrote: >> such that you only have to have one label, instead of adding a new >> label? All three instances follow the same pattern. >> > > Here's v2 attached. I also removed two already existing success labels. ACK to this version. -- Eric Blake ebl...@

Re: [libvirt] [PATCH] esx: Fix memory leak when looking up an non-existing domain by name

2010-08-15 Thread Matthias Bolte
2010/8/10 Eric Blake : > On 08/08/2010 02:56 PM, Matthias Bolte wrote: >> In case an optional object cannot be found the lookup function is >> left early and the cleanup code is not executed. Add a success label >> and goto instead of an early return. >> >> This pattern occurs in some other functio

Re: [libvirt] [PATCH] esx: Fix memory leak when looking up an non-existing domain by name

2010-08-09 Thread Eric Blake
On 08/08/2010 02:56 PM, Matthias Bolte wrote: > In case an optional object cannot be found the lookup function is > left early and the cleanup code is not executed. Add a success label > and goto instead of an early return. > > This pattern occurs in some other functions too. > --- > src/esx/esx_

[libvirt] [PATCH] esx: Fix memory leak when looking up an non-existing domain by name

2010-08-08 Thread Matthias Bolte
In case an optional object cannot be found the lookup function is left early and the cleanup code is not executed. Add a success label and goto instead of an early return. This pattern occurs in some other functions too. --- src/esx/esx_vi.c | 14 -- 1 files changed, 8 insertions(+)

Re: [libvirt] [PATCH] esx: Fix memory leak in esxVI_HostCpuIdInfo_Free()

2009-11-15 Thread Daniel Veillard
On Sat, Nov 14, 2009 at 11:02:15PM +0100, Matthias Bolte wrote: > --- > src/esx/esx_vi_types.c |1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/src/esx/esx_vi_types.c b/src/esx/esx_vi_types.c > index 73d3069..9af9f73 100644 > --- a/src/esx/esx_vi_types.c > +++ b/src/e

[libvirt] [PATCH] esx: Fix memory leak in esxVI_HostCpuIdInfo_Free()

2009-11-14 Thread Matthias Bolte
--- src/esx/esx_vi_types.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/src/esx/esx_vi_types.c b/src/esx/esx_vi_types.c index 73d3069..9af9f73 100644 --- a/src/esx/esx_vi_types.c +++ b/src/esx/esx_vi_types.c @@ -1496,6 +1496,7 @@ ESX_VI__TEMPLATE__FREE(HostCpuIdInfo, {

Re: [libvirt] [PATCH] ESX: Fix memory leak in list handling functions.

2009-10-28 Thread Daniel P. Berrange
On Wed, Oct 28, 2009 at 09:12:57PM +0100, Matthias Bolte wrote: > If an error occurs between the allocation of an item and appending it > to the list, the item leaks. Free such orphaned items in error cases. > > * src/esx/esx_vi.c: free orphaned items in error cases > --- > src/esx/esx_vi.c | 2

[libvirt] [PATCH] ESX: Fix memory leak in list handling functions.

2009-10-28 Thread Matthias Bolte
If an error occurs between the allocation of an item and appending it to the list, the item leaks. Free such orphaned items in error cases. * src/esx/esx_vi.c: free orphaned items in error cases --- src/esx/esx_vi.c | 24 1 files changed, 8 insertions(+), 16 deletions(-