Re: [libvirt] [PATCH] event: move event filtering to daemon (regression fix)

2014-02-05 Thread Eric Blake
On 01/28/2014 03:48 PM, Eric Blake wrote: Commit f9f56340 for CVE-2014-0028 almost had the right idea - we need to check the ACL rules to filter which events to send. But it overlooked one thing: the event dispatch queue is running in the main loop thread, and therefore does not normally have

Re: [libvirt] [PATCH] event: move event filtering to daemon (regression fix)

2014-02-05 Thread Daniel P. Berrange
On Tue, Jan 28, 2014 at 03:48:19PM -0700, Eric Blake wrote: Commit f9f56340 for CVE-2014-0028 almost had the right idea - we need to check the ACL rules to filter which events to send. But it overlooked one thing: the event dispatch queue is running in the main loop thread, and therefore does

Re: [libvirt] [PATCH] event: move event filtering to daemon (regression fix)

2014-02-05 Thread Eric Blake
On 02/05/2014 06:56 AM, Daniel P. Berrange wrote: On Tue, Jan 28, 2014 at 03:48:19PM -0700, Eric Blake wrote: Commit f9f56340 for CVE-2014-0028 almost had the right idea - we need to check the ACL rules to filter which events to send. But it overlooked one thing: the event dispatch queue is

[libvirt] [PATCH] event: move event filtering to daemon (regression fix)

2014-01-28 Thread Eric Blake
Commit f9f56340 for CVE-2014-0028 almost had the right idea - we need to check the ACL rules to filter which events to send. But it overlooked one thing: the event dispatch queue is running in the main loop thread, and therefore does not normally have a current virIdentityPtr. But filter checks