Re: [libvirt] [PATCH] examples: Fix installation on Windows

2019-05-17 Thread Daniel P . Berrangé
On Mon, May 13, 2019 at 02:55:14PM +0200, Andrea Bolognani wrote: > We can't rely on $(noinst_PROGRAMS) retaining its original > value, so let's use a separate $(EXAMPLES) variable instead. > > Signed-off-by: Andrea Bolognani > --- > examples/Makefile.am | 35 ---

Re: [libvirt] [PATCH] examples: Fix installation on Windows

2019-05-15 Thread Andrea Bolognani
On Tue, 2019-05-14 at 11:59 +0200, Andrea Bolognani wrote: > On Tue, 2019-05-14 at 10:16 +0100, Daniel P. Berrangé wrote: > > On Tue, May 14, 2019 at 09:21:12AM +0200, Andrea Bolognani wrote: > > > On Mon, 2019-05-13 at 16:14 +0100, Daniel P. Berrangé wrote: > > > > I wonder if we should just

Re: [libvirt] [PATCH] examples: Fix installation on Windows

2019-05-14 Thread Andrea Bolognani
On Tue, 2019-05-14 at 10:16 +0100, Daniel P. Berrangé wrote: > On Tue, May 14, 2019 at 09:21:12AM +0200, Andrea Bolognani wrote: > > On Mon, 2019-05-13 at 16:14 +0100, Daniel P. Berrangé wrote: > > > I wonder if we should just directly use the _SOURCES vars instead of > > > making > > > the

Re: [libvirt] [PATCH] examples: Fix installation on Windows

2019-05-14 Thread Daniel P . Berrangé
On Tue, May 14, 2019 at 09:21:12AM +0200, Andrea Bolognani wrote: > On Mon, 2019-05-13 at 16:14 +0100, Daniel P. Berrangé wrote: > > On Mon, May 13, 2019 at 02:55:14PM +0200, Andrea Bolognani wrote: > > > +# List of example programs. We need to list them here instead of using > > > +#

Re: [libvirt] [PATCH] examples: Fix installation on Windows

2019-05-14 Thread Andrea Bolognani
On Mon, 2019-05-13 at 16:14 +0100, Daniel P. Berrangé wrote: > On Mon, May 13, 2019 at 02:55:14PM +0200, Andrea Bolognani wrote: > > +# List of example programs. We need to list them here instead of using > > +# $(noinst_PROGRAMS) directly because we want to have access to the > > +# unmodified

Re: [libvirt] [PATCH] examples: Fix installation on Windows

2019-05-13 Thread Daniel P . Berrangé
On Mon, May 13, 2019 at 02:55:14PM +0200, Andrea Bolognani wrote: > We can't rely on $(noinst_PROGRAMS) retaining its original > value, so let's use a separate $(EXAMPLES) variable instead. > > Signed-off-by: Andrea Bolognani > --- > examples/Makefile.am | 35 ---

[libvirt] [PATCH] examples: Fix installation on Windows

2019-05-13 Thread Andrea Bolognani
We can't rely on $(noinst_PROGRAMS) retaining its original value, so let's use a separate $(EXAMPLES) variable instead. Signed-off-by: Andrea Bolognani --- examples/Makefile.am | 35 --- 1 file changed, 28 insertions(+), 7 deletions(-) diff --git