Re: [libvirt PATCH] Fix incorrect uses of g_clear_pointer() introduced in 8.1.0

On a Monday in 2022, Mark Mielke wrote: Sounds good - thank you... Patch is Signed-off-by: Mark Mielke Thanks, pushed now. Jano signature.asc Description: PGP signature

Re: [libvirt PATCH] Fix incorrect uses of g_clear_pointer() introduced in 8.1.0

Sounds good - thank you... Patch is Signed-off-by: Mark Mielke On Mon, Jun 13, 2022 at 5:08 AM Ján Tomko wrote: > On a Sunday in 2022, Mark Mielke wrote: > >This is a partial revert of 87a43a907f0ad4897a28ad7c216bc70f37270b93. > > I'll drop the trailing period before pushing. > > > > >The

Re: [libvirt PATCH] Fix incorrect uses of g_clear_pointer() introduced in 8.1.0

On a Sunday in 2022, Mark Mielke wrote: This is a partial revert of 87a43a907f0ad4897a28ad7c216bc70f37270b93. I'll drop the trailing period before pushing. The change to use g_clear_pointer() in more places was accidentally applied to cases involving vir_g_source_unref(). In some cases,

[libvirt PATCH] Fix incorrect uses of g_clear_pointer() introduced in 8.1.0

This is a partial revert of 87a43a907f0ad4897a28ad7c216bc70f37270b93. The change to use g_clear_pointer() in more places was accidentally applied to cases involving vir_g_source_unref(). In some cases, the ordering of g_source_destroy() and vir_g_source_unref() was reversed, which resulted in

Re: [libvirt PATCH] Fix typos

On a Wednesday in 2022, Tim Wiederhake wrote: Signed-off-by: Tim Wiederhake --- src/qemu/qemu_fd.c | 2 +- src/util/virfile.c | 2 +- tests/meson.build | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) Reviewed-by: Ján Tomko Jano signature.asc Description: PGP signature

[libvirt PATCH] Fix typos

Signed-off-by: Tim Wiederhake --- src/qemu/qemu_fd.c | 2 +- src/util/virfile.c | 2 +- tests/meson.build | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/qemu/qemu_fd.c b/src/qemu/qemu_fd.c index bc6a37663c..6311161657 100644 --- a/src/qemu/qemu_fd.c +++

Re: [libvirt PATCH] Fix copy-paste error in virNetServerSetClientAuthenticated

On 4/19/22 17:11, Tim Wiederhake wrote: > Fixes: db16792aa90cab5c9886fc2990ec13fbb20a3fb5 > Signed-off-by: Tim Wiederhake > --- > src/rpc/virnetserver.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/rpc/virnetserver.c b/src/rpc/virnetserver.c > index

[libvirt PATCH] Fix copy-paste error in virNetServerSetClientAuthenticated

Fixes: db16792aa90cab5c9886fc2990ec13fbb20a3fb5 Signed-off-by: Tim Wiederhake --- src/rpc/virnetserver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/rpc/virnetserver.c b/src/rpc/virnetserver.c index 9b333f1a6c..371b72c8d6 100644 --- a/src/rpc/virnetserver.c +++

Re: [libvirt PATCH] Fix spelling

On Wed, Mar 30, 2022 at 04:46:32PM +0200, Tim Wiederhake wrote: > Signed-off-by: Tim Wiederhake > --- > ci/integration.yml | 8 > docs/drvqemu.rst | 6 +++--- > src/qemu/qemu_capabilities.h | 2 +- > src/qemu/qemu_domain.c | 2 +- > 4 files changed, 9

Re: [libvirt PATCH] fix documentation for sockets topology

On Tue, Mar 29, 2022 at 06:38:11PM +0100, John Levon wrote: > From: John Levon > > In 0895a0e, it was noted that the "sockets" value in the topology > section of capabilities reflects not the number of sockets per NUMA > node, not the total number. > > Unfortunately, the fix was applied to the

[libvirt PATCH] Fix spelling

Signed-off-by: Tim Wiederhake --- ci/integration.yml | 8 docs/drvqemu.rst | 6 +++--- src/qemu/qemu_capabilities.h | 2 +- src/qemu/qemu_domain.c | 2 +- 4 files changed, 9 insertions(+), 9 deletions(-) diff --git a/ci/integration.yml b/ci/integration.yml

[libvirt PATCH] fix documentation for sockets topology

From: John Levon In 0895a0e, it was noted that the "sockets" value in the topology section of capabilities reflects not the number of sockets per NUMA node, not the total number. Unfortunately, the fix was applied to the wrong place: the domain XML format documentation, not that for the

Re: [libvirt PATCH] Fix some typos

On 12/14/21 16:01, Tim Wiederhake wrote: > Signed-off-by: Tim Wiederhake > --- > docs/manpages/virsh.rst | 2 +- > src/qemu/qemu_domain.h | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Michal Privoznik Michal

[libvirt PATCH] Fix some typos

Signed-off-by: Tim Wiederhake --- docs/manpages/virsh.rst | 2 +- src/qemu/qemu_domain.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/manpages/virsh.rst b/docs/manpages/virsh.rst index 275f416090..265725d214 100644 --- a/docs/manpages/virsh.rst +++

Re: [libvirt PATCH] Fix typos

On Fri, Sep 17, 2021 at 01:07:02PM +0200, Tim Wiederhake wrote: > Signed-off-by: Tim Wiederhake > --- > src/ch/ch_monitor.c| 2 +- > tests/virstoragetest.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) Trivial. Reviewed-by: Erik Skultety

[libvirt PATCH] Fix typos

Signed-off-by: Tim Wiederhake --- src/ch/ch_monitor.c| 2 +- tests/virstoragetest.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/ch/ch_monitor.c b/src/ch/ch_monitor.c index 4ed7cbfee7..d277466262 100644 --- a/src/ch/ch_monitor.c +++ b/src/ch/ch_monitor.c @@

Re: [libvirt PATCH] Fix MinGW pipeline after 49cb59778a4e6c2d04bb9383a9d97fbbc83f9fce

On Fri, Jan 08, 2021 at 12:15:04 +0100, Erik Skultety wrote: Please always describe what you are fixing. The commit message including summary doesn't shed any light what the problem was. Even if it was false positive. Also I'm pretty sure this breaks migw builds even outside of our CI. >

[libvirt PATCH] Fix MinGW pipeline after 49cb59778a4e6c2d04bb9383a9d97fbbc83f9fce

Signed-off-by: Erik Skultety --- personal pipeline: https://gitlab.com/eskultety/libvirt/-/pipelines/239002989 Pushed under the build breaker rule. src/util/virmdev.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/util/virmdev.c b/src/util/virmdev.c index

[libvirt PATCH] Fix capitalization "CLang" -> "Clang"

Signed-off-by: Andrea Bolognani --- Pushed as trivial. config.h | 2 +- docs/programming-languages.rst | 2 +- meson.build| 4 ++-- tests/qemusecuritymock.c | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/config.h b/config.h

Re: [libvirt PATCH] Fix name prefix of VIR_DOMAIN_CHECKPOINT_REDEFINE_VALIDATE

On Mon, Nov 09, 2020 at 16:17:15 +, Daniel Berrange wrote: > The enum constant names should all have a prefix that matches the enum > name. VIR_DOMAIN_CHECKPOINT_REDEFINE_VALIDATE was missing the "CREATE_" > part of the name prefix. > > Signed-off-by: Daniel P. Berrangé > --- Reviewed-by:

[libvirt PATCH] Fix name prefix of VIR_DOMAIN_CHECKPOINT_REDEFINE_VALIDATE

The enum constant names should all have a prefix that matches the enum name. VIR_DOMAIN_CHECKPOINT_REDEFINE_VALIDATE was missing the "CREATE_" part of the name prefix. Signed-off-by: Daniel P. Berrangé --- include/libvirt/libvirt-domain-checkpoint.h | 4 ++-- src/libvirt-domain-checkpoint.c

Re: [libvirt PATCH] Fix incorrect g_new0 conversions

On Tue, Oct 06, 2020 at 03:05:11PM +0200, Ján Tomko wrote: On a Tuesday in 2020, Martin Kletzander wrote: On Tue, Oct 06, 2020 at 01:15:01PM +0200, Ján Tomko wrote: I left in a 'return' or 'goto cleanup' in a few places that where I did the conversion manually. Did you mean s/that// maybe?

Re: [libvirt PATCH] Fix incorrect g_new0 conversions

On a Tuesday in 2020, Martin Kletzander wrote: On Tue, Oct 06, 2020 at 01:15:01PM +0200, Ján Tomko wrote: I left in a 'return' or 'goto cleanup' in a few places that where I did the conversion manually. Did you mean s/that// maybe? Thanks, I fixed it before you pointed it out. Did you

Re: [libvirt PATCH] Fix incorrect g_new0 conversions

On Tue, Oct 06, 2020 at 01:15:01PM +0200, Ján Tomko wrote: I left in a 'return' or 'goto cleanup' in a few places that where I did the conversion manually. Did you mean s/that// maybe? Signed-off-by: Ján Tomko Reported-by: John Ferlan --- src/esx/esx_storage_backend_vmfs.c | 1 -

Re: [libvirt PATCH] Fix incorrect g_new0 conversions

On 10/6/20 7:15 AM, Ján Tomko wrote: > I left in a 'return' or 'goto cleanup' in a few places that > where I did the conversion manually. > > Signed-off-by: Ján Tomko > Reported-by: John Ferlan > --- > src/esx/esx_storage_backend_vmfs.c | 1 - > src/libxl/libxl_capabilities.c

[libvirt PATCH] Fix incorrect g_new0 conversions

I left in a 'return' or 'goto cleanup' in a few places that where I did the conversion manually. Signed-off-by: Ján Tomko Reported-by: John Ferlan --- src/esx/esx_storage_backend_vmfs.c | 1 - src/libxl/libxl_capabilities.c | 2 -- src/libxl/libxl_driver.c

Re: [libvirt PATCH] Fix allocation of virDomainFSDef

On Thu, 2020-06-18 at 15:55 +0200, Ján Tomko wrote: > On a Thursday in 2020, Andrea Bolognani wrote: > > On Thu, 2020-06-18 at 14:13 +0200, Ján Tomko wrote: > > > Some less commonly used drivers were omitted when we switched > > > the allocator from a plain VIR_ALLOC to virDomainFSDefNew. > > > >

Re: [libvirt PATCH] Fix allocation of virDomainFSDef

On a Thursday in 2020, Andrea Bolognani wrote: On Thu, 2020-06-18 at 14:13 +0200, Ján Tomko wrote: Some less commonly used drivers were omitted when we switched the allocator from a plain VIR_ALLOC to virDomainFSDefNew. Signed-off-by: Ján Tomko Fixes: da665fbd4858890fbb3bbf5da2a7b6ca37bb3220

Re: [libvirt PATCH] Fix allocation of virDomainFSDef

On Thu, 2020-06-18 at 14:13 +0200, Ján Tomko wrote: > Some less commonly used drivers were omitted when we switched > the allocator from a plain VIR_ALLOC to virDomainFSDefNew. > > Signed-off-by: Ján Tomko > Fixes: da665fbd4858890fbb3bbf5da2a7b6ca37bb3220 > >

[libvirt PATCH] Fix allocation of virDomainFSDef

Some less commonly used drivers were omitted when we switched the allocator from a plain VIR_ALLOC to virDomainFSDefNew. Signed-off-by: Ján Tomko Fixes: da665fbd4858890fbb3bbf5da2a7b6ca37bb3220 https://bugzilla.redhat.com/show_bug.cgi?id=1846450 --- src/openvz/openvz_conf.c | 2 +-

Re: [libvirt PATCH] fix build by NULL string handling

On Mon, Apr 6, 2020 at 4:39 PM Daniel P. Berrangé wrote: > On Mon, Apr 06, 2020 at 04:16:48PM +0530, Mishal Shah wrote: > > On Mon, Apr 6, 2020 at 3:57 PM Daniel P. Berrangé > > wrote: > > > > > On Mon, Apr 06, 2020 at 03:49:36PM +0530, Mishal Shah wrote: > > > > Fix libvirt build by taking

Re: [libvirt PATCH] fix build by NULL string handling

On Mon, Apr 06, 2020 at 04:16:48PM +0530, Mishal Shah wrote: > On Mon, Apr 6, 2020 at 3:57 PM Daniel P. Berrangé > wrote: > > > On Mon, Apr 06, 2020 at 03:49:36PM +0530, Mishal Shah wrote: > > > Fix libvirt build by taking care of NULL string handling > > > > What build problems are you seeing

Re: [libvirt PATCH] fix build by NULL string handling

On Mon, Apr 6, 2020 at 3:57 PM Daniel P. Berrangé wrote: > On Mon, Apr 06, 2020 at 03:49:36PM +0530, Mishal Shah wrote: > > Fix libvirt build by taking care of NULL string handling > > What build problems are you seeing without this patch ? Our automated > CI is all working correctly and I

Re: [libvirt PATCH] fix build by NULL string handling

On Mon, Apr 06, 2020 at 03:49:36PM +0530, Mishal Shah wrote: > Fix libvirt build by taking care of NULL string handling What build problems are you seeing without this patch ? Our automated CI is all working correctly and I don't think the changes make sense. > --- > src/openvz/openvz_driver.c

[libvirt PATCH] fix build by NULL string handling

Fix libvirt build by taking care of NULL string handling --- src/openvz/openvz_driver.c | 6 +- tests/sockettest.c | 8 ++-- 2 files changed, 11 insertions(+), 3 deletions(-) diff --git a/src/openvz/openvz_driver.c b/src/openvz/openvz_driver.c index 1a189dbbe7..46f117cd00 100644

[libvirt PATCH] fix paths to openrc.init.in files

The inc.am Makfiles are included by src/Makefile.am. Adjust the paths added to OPENRC_INIT_FILES_IN accordingly. Signed-off-by: Ján Tomko Fixes: f4b1c020a2c8493473bf868231cee6a952d57e6f --- Pushed as a build fix. src/locking/Makefile.inc.am | 2 +- src/logging/Makefile.inc.am | 2 +- 2 files

[libvirt] [PATCH] Fix typo (cetificate -> certificate)

Signed-off-by: Andrea Bolognani --- Pushed as trivial. docs/manpages/virsh.rst | 2 +- include/libvirt/libvirt-domain.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/manpages/virsh.rst b/docs/manpages/virsh.rst index 6446a903ca..c637caa583 100644 ---

Re: [libvirt] [PATCH] fix class type instantiated when listing network ports

On Thu, Jan 02, 2020 at 03:47:31PM +, Daniel P. Berrangé wrote: > Signed-off-by: Daniel P. Berrangé > --- > libvirt-override-virNetwork.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libvirt-override-virNetwork.py b/libvirt-override-virNetwork.py > index

[libvirt] [PATCH] fix class type instantiated when listing network ports

Signed-off-by: Daniel P. Berrangé --- libvirt-override-virNetwork.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libvirt-override-virNetwork.py b/libvirt-override-virNetwork.py index 749ee44..4245322 100644 --- a/libvirt-override-virNetwork.py +++

Re: [libvirt] [PATCH] Fix src/ pkg-config API XML paths

On Mon, Dec 09, 2019 at 07:26:13PM -0500, Cole Robinson wrote: > On 12/9/19 9:08 AM, Daniel P. Berrangé wrote: > > On Mon, Dec 09, 2019 at 09:02:56AM -0500, Cole Robinson wrote: > >> The .pc files in src/ are intended for use with the ./run script, > >> to ease building bindings against an

Re: [libvirt] [PATCH] Fix src/ pkg-config API XML paths

On Mon, Dec 09, 2019 at 09:02:56AM -0500, Cole Robinson wrote: > The .pc files in src/ are intended for use with the ./run script, > to ease building bindings against an uninstalled libvirt build. > The pointer to the API XML files is incorrect though, it needs to > point into the build tree. > >

Re: [libvirt] [PATCH] Fix src/ pkg-config API XML paths

On 12/9/19 9:08 AM, Daniel P. Berrangé wrote: > On Mon, Dec 09, 2019 at 09:02:56AM -0500, Cole Robinson wrote: >> The .pc files in src/ are intended for use with the ./run script, >> to ease building bindings against an uninstalled libvirt build. >> The pointer to the API XML files is incorrect

Re: [libvirt] [PATCH] Fix src/ pkg-config API XML paths

On Mon, Dec 09, 2019 at 09:02:56AM -0500, Cole Robinson wrote: > The .pc files in src/ are intended for use with the ./run script, > to ease building bindings against an uninstalled libvirt build. > The pointer to the API XML files is incorrect though, it needs to > point into the build tree. > >

[libvirt] [PATCH] Fix src/ pkg-config API XML paths

The .pc files in src/ are intended for use with the ./run script, to ease building bindings against an uninstalled libvirt build. The pointer to the API XML files is incorrect though, it needs to point into the build tree. This fixes use of the run script for building libvirt-python, ex:

Re: [libvirt] [PATCH] Fix bug libvirt daemon segfault when new force console vm session break down existed console session. When force console vm command arrived, libvirtd will break down existed cons

Ok, thanks. Michal Privoznik 于2019年11月28日周四 下午5:21写道： > On 11/28/19 4:03 AM, Lance Liu wrote: > > Ok, I'll check it out. > > > > Look like your patch is still not in master branch。May you commit it? > > I'll check out it and test for force console case > > Unfortunately, it did not receive any

Re: [libvirt] [PATCH] Fix bug libvirt daemon segfault when new force console vm session break down existed console session. When force console vm command arrived, libvirtd will break down existed cons

On 11/28/19 4:03 AM, Lance Liu wrote: Ok, I'll check it out. Look like your patch is still not in master branch。May you commit it? I'll check out it and test for force console case Unfortunately, it did not receive any ACK from a contributor with commit rights (which is required for any

Re: [libvirt] [PATCH] Fix bug libvirt daemon segfault when new force console vm session break down existed console session. When force console vm command arrived, libvirtd will break down existed cons

Ok, I'll check it out. Look like your patch is still not in master branch。May you commit it? I'll check out it and test for force console case Michal Privoznik 于2019年11月25日周一 下午10:12写道： > On 11/25/19 11:53 AM, Lance Liu wrote: > > We first produce this bug in rhel7.4's libvir daemon。For easily

Re: [libvirt] [PATCH] Fix bug libvirt daemon segfault when new force console vm session break down existed console session. When force console vm command arrived, libvirtd will break down existed cons

On 11/25/19 11:53 AM, Lance Liu wrote: We first produce this bug in rhel7.4's libvir daemon。For easily produce the bug, the step can be as follows: 1. add sleep(3) in daemonStreamFilter() pre virMutexLock(>priv->lock), then build libvirtd bin executable, then restart libvirtd 2. use virsh

Re: [libvirt] [PATCH] Fix bug libvirt daemon segfault when new force console vm session break down existed console session. When force console vm command arrived, libvirtd will break down existed cons

We first produce this bug in rhel7.4's libvir daemon。For easily produce the bug, the step can be as follows: 1. add sleep(3) in daemonStreamFilter() pre virMutexLock(>priv->lock), then build libvirtd bin executable, then restart libvirtd 2. use virsh console open one vm's console, for this

Re: [libvirt] [PATCH] Fix bug libvirt daemon segfault when new force console vm session break down existed console session. When force console vm command arrived, libvirtd will break down existed cons

On 11/25/19 8:34 AM, LanceLiu wrote: --- src/libvirt_remote.syms | 1 + src/remote/remote_daemon_stream.c | 10 +- src/rpc/virnetserverclient.c | 12 src/rpc/virnetserverclient.h | 2 ++ 4 files changed, 24 insertions(+), 1 deletion(-) Please

Re: [libvirt] [PATCH] Fix bug libvirt daemon segfault when new force console vm session break down existed console session. When force console vm command arrived, libvirtd will break down existed cons

Previous patch can not pass build because of missing virNetServerClientCheckFilterExist stated in libvirt_remote.syms LanceLiu 于2019年11月25日周一 下午3:34写道： > --- > src/libvirt_remote.syms | 1 + > src/remote/remote_daemon_stream.c | 10 +- > src/rpc/virnetserverclient.c |

[libvirt] [PATCH] Fix bug libvirt daemon segfault when new force console vm session break down existed console session. When force console vm command arrived, libvirtd will break down existed console

--- src/libvirt_remote.syms | 1 + src/remote/remote_daemon_stream.c | 10 +- src/rpc/virnetserverclient.c | 12 src/rpc/virnetserverclient.h | 2 ++ 4 files changed, 24 insertions(+), 1 deletion(-) diff --git a/src/libvirt_remote.syms

[libvirt] [PATCH] Fix bug libvirt daemon segfault when new force console vm session break down existed console session. When force console vm command arrived, libvirtd will break down existed console

--- src/remote/remote_daemon_stream.c | 10 +- src/rpc/virnetserverclient.c | 12 src/rpc/virnetserverclient.h | 2 ++ 3 files changed, 23 insertions(+), 1 deletion(-) diff --git a/src/remote/remote_daemon_stream.c b/src/remote/remote_daemon_stream.c index

Re: [libvirt] [PATCH] fix bug libvirt daemon deadlock when another force console break down an existed console client when this deadlock hanppened, libvirtd backtrace as follow, a typical ABBA deadloc

Thank you! But it looks like libvirtd daemon stream module still has bug lead to process segfault if applied this patch(if not, it will lead libvirtd deadlock).I have got the cause, but it seems difficult to fix it with present codes。 Bug reproduce: 1. add sleep(3) in daemonStreamFilter() so it is

Re: [libvirt] [PATCH] fix bug libvirt daemon deadlock when another force console break down an existed console client when this deadlock hanppened, libvirtd backtrace as follow, a typical ABBA deadloc

On 11/22/19 8:00 AM, Lance Liu wrote: Thank you! But it looks like libvirtd daemon stream module still has bug lead to process segfault if applied this patch(if not, it will lead libvirtd deadlock).I have got the cause, but it seems difficult to fix it with present codes。 Bug reproduce: 1.

Re: [libvirt] [PATCH] fix bug libvirt daemon deadlock when another force console break down an existed console client when this deadlock hanppened, libvirtd backtrace as follow, a typical ABBA deadloc

On 11/19/19 12:39 PM, LanceLiu wrote: (gdb) thread 23 [Switching to thread 23 (Thread 0x7fbb54810700 (LWP 296966))] (gdb) bt at rpc/virnetserverclient.c:1503 client=client@entry=0x5641d20e20a0, msg=0x7fbb08003ab0, rerr=rerr@entry=0x7fbb5480f7b0, procedure=201, type=type@entry=3,

[libvirt] [PATCH] fix bug libvirt daemon deadlock when another force console break down an existed console client when this deadlock hanppened, libvirtd backtrace as follow, a typical ABBA deadlock ci

(gdb) thread 23 [Switching to thread 23 (Thread 0x7fbb54810700 (LWP 296966))] (gdb) bt at rpc/virnetserverclient.c:1503 client=client@entry=0x5641d20e20a0, msg=0x7fbb08003ab0, rerr=rerr@entry=0x7fbb5480f7b0, procedure=201, type=type@entry=3, serial=9) at rpc/virnetserverprogram.c:173

Re: [libvirt] [PATCH] fix memleak in virNodeDeviceGetPCISRIOVCaps

On 9/12/19 10:05 AM, Yi Wang wrote: From: Jiang Kun it always alloc new memory when get dumpxml of pf device,but never free it. Now free the old first,then alloc new memory. Signed-off-by: Jiang kun --- src/conf/node_device_conf.c | 1 + 1 file changed, 1 insertion(+) Reviewed-by:

[libvirt] [PATCH] fix memleak in virNodeDeviceGetPCISRIOVCaps

From: Jiang Kun it always alloc new memory when get dumpxml of pf device,but never free it. Now free the old first,then alloc new memory. Signed-off-by: Jiang kun --- src/conf/node_device_conf.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/conf/node_device_conf.c

Re: [libvirt] [PATCH] Fix 'validate' typo in comments

On Thu, Jun 20, 2019 at 14:36:18 -0500, Jonathon Jongsma wrote: > Signed-off-by: Jonathon Jongsma > --- > src/conf/domain_conf.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Pushed now. signature.asc Description: PGP signature -- libvir-list mailing list libvir-list@redhat.com

[libvirt] [PATCH] Fix 'validate' typo in comments

Signed-off-by: Jonathon Jongsma --- src/conf/domain_conf.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index d06e094b11..8604ba63d4 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -21375,7 +21375,7 @@

[libvirt] [PATCH] Fix regression in lxcOpenNamespace

This fixes regression caused by the 1d39dbaf637db03f6e597ed56b96aa065710b4a1 fdlist[i] erroneously was replaced by fdlist[1] which caused lxcOpenNamespace to return a list with identical elements. --- libvirt-lxc-override.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[libvirt] [PATCH] Fix spelling for macOS

Though it used to be called "Mac OS X" and "OS X" in the past, it was never "MacOS X" nor "OS-X", and it's just "macOS" now. Signed-off-by: Andrea Bolognani --- Pushed as trivial. configure.ac | 10 +- m4/virt-driver-network.m4 | 4 ++-- m4/virt-driver-qemu.m4| 2 +-

Re: [libvirt] [PATCH] Fix the recent CI build failures

Please describe the change being made in the commit summary, e.g: conf: initialize variables in virDomainThreadSchedParseHelper The 'why?' fits better in the body of the commit message. Jano On Tue, Mar 05, 2019 at 10:09:23AM +0100, Erik Skultety wrote: After commits e2087c2 and ec0793de

[libvirt] [PATCH] Fix the recent CI build failures

After commits e2087c2 and ec0793de older GCC started act very smart and complain about potentially uninitialized variable, which existed prior to these patches + even if the affected vars were left uninitialized the function responsible for filling them in would have failed with NULL being

[libvirt] [PATCH] Fix header ifdef check for config-post.h in VPATH build

We must do a substring match, not an exact match since there can be an arbitrary virtual path prepended. Signed-off-by: Daniel P. Berrangé --- Pushed as a build fix build-aux/header-ifdef.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/build-aux/header-ifdef.pl

Re: [libvirt] [PATCH] Fix minor typos in messages and docs

From 89a859c1229283cdb8d8e877ee1a81972f7e5af1 Mon Sep 17 00:00:00 2001 From: Yuri Chornoivan Date: Tue, 4 Dec 2018 19:08:14 +0200 Subject: [PATCH] Fix minor typos in messages and docs Signed-off-by: Yuri Chornoivan --- config-post.h | 2 +-

[libvirt] [PATCH] Fix minor typos in messages and docs

Hi, Please find the attached patch with minor fixes. Many thanks in advance for reviewing it. Best regards, Yuri>From 89a859c1229283cdb8d8e877ee1a81972f7e5af1 Mon Sep 17 00:00:00 2001 From: Yuri Chornoivan Date: Tue, 4 Dec 2018 19:08:14 +0200 Subject: [PATCH] Fix minor typos in messages and

[libvirt] [PATCH] Fix build on non-linux platforms after another VIR_AUTOPTR patches

Caused by commit f7d0663d49. The problem is missing libnl library on these platforms, so the VIR_DEFINE_AUTOPTR_FUNC has to be compiled in conditionally. Signed-off-by: Erik Skultety --- Checked with Travis CI, local fedora with MinGW and FreeBSD, thus pushed under the build breaker rule.

Re: [libvirt] [PATCH] Fix link errors in tools/nss and tests

On 08/09/2018 07:15 PM, Jim Fehlig wrote: > > I tested the patch, works fine. What is the best course of action since > I pushed the other one? Revert it and push your patch? No need to revert. I'll send a patch that moves DLOPEN_* where I suggested. Michal -- libvir-list mailing list

Re: [libvirt] [PATCH] Fix libvirt-driver-libxl check

On 08/05/2018 03:50 PM, Marek Marczykowski-Górecki wrote: Fix saving CFLAGS in LIBVIRT_DRIVER_CHECK_LIBXL - LIBVIRT_CHECK_LIB will override old_CFLAGS, so use a different name. Signed-off-by: Marek Marczykowski-Górecki Reviewed-by: Jim Fehlig and pushed. Regards, Jim ---

Re: [libvirt] [PATCH] Fix link errors in tools/nss and tests

On 08/09/2018 07:42 AM, Michal Privoznik wrote: On 08/08/2018 07:00 PM, Jim Fehlig wrote: While local builds succeed fine, a build worker building in a chroot environment is encountering errors when linking some items in tools/nss and tests, e.g. [ 469s] libtool: link: gcc -shared -fPIC

Re: [libvirt] [PATCH] Fix link errors in tools/nss and tests

On 08/08/2018 07:00 PM, Jim Fehlig wrote: > While local builds succeed fine, a build worker building in a chroot > environment is encountering errors when linking some items in tools/nss > and tests, e.g. > > [ 469s] libtool: link: gcc -shared -fPIC -DPIC -Wl,--whole-archive >

Re: [libvirt] [PATCH] Fix link errors in tools/nss and tests

On Wed, Aug 08, 2018 at 11:00:01AM -0600, Jim Fehlig wrote: > While local builds succeed fine, a build worker building in a chroot > environment is encountering errors when linking some items in tools/nss > and tests, e.g. > > [ 469s] libtool: link: gcc -shared -fPIC -DPIC -Wl,--whole-archive

[libvirt] [PATCH] Fix link errors in tools/nss and tests

While local builds succeed fine, a build worker building in a chroot environment is encountering errors when linking some items in tools/nss and tests, e.g. [ 469s] libtool: link: gcc -shared -fPIC -DPIC -Wl,--whole-archive nss/.libs/libnss_libvirt_impl.a -Wl,--no-whole-archive -lpthread

[libvirt] [PATCH] Fix snapshot creating with vm xml persistent

Bobo Du (1): qemu:Fix snapshot creating with vm xml persistent src/qemu/qemu_driver.c | 1 + 1 file changed, 1 insertion(+) -- 1.8.3.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] Fix include for xattr.h

On Mon, Aug 06, 2018 at 10:31:07AM +0200, Martin Kletzander wrote: > The proper file that should be included is `sys/xattr.h` as that comes from > `glibc` and not `attr/xattr.h` which ships with the `attr` utility. > > We're most probably not the only ones because `attr/xattr.h` added a #warning

[libvirt] [PATCH] Fix include for xattr.h

The proper file that should be included is `sys/xattr.h` as that comes from `glibc` and not `attr/xattr.h` which ships with the `attr` utility. We're most probably not the only ones because `attr/xattr.h` added a #warning to their include resulting in the following compilation errors: In file

[libvirt] [PATCH] Fix libvirt-driver-libxl check

Fix saving CFLAGS in LIBVIRT_DRIVER_CHECK_LIBXL - LIBVIRT_CHECK_LIB will override old_CFLAGS, so use a different name. Signed-off-by: Marek Marczykowski-Górecki --- m4/virt-driver-libxl.m4 | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/m4/virt-driver-libxl.m4

Re: [libvirt] [PATCH] Fix syntax error on Python 3.7

On 27.6.2018 13:54, Miro Hrončok wrote: On 27.6.2018 13:47, Pavel Hrdina wrote: On Wed, Jun 27, 2018 at 01:03:03PM +0200, Miro Hrončok wrote:  From 0d3b7cc9ba787a139ecbe6dac490b1f5bb021b7f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Miro=20Hron=C4=8Dok?= Date: Wed, 27 Jun 2018 13:00:28 +0200

Re: [libvirt] [PATCH] Fix syntax error on Python 3.7

On 27.6.2018 13:47, Pavel Hrdina wrote: On Wed, Jun 27, 2018 at 01:03:03PM +0200, Miro Hrončok wrote: From 0d3b7cc9ba787a139ecbe6dac490b1f5bb021b7f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Miro=20Hron=C4=8Dok?= Date: Wed, 27 Jun 2018 13:00:28 +0200 Subject: [PATCH] Fix syntax error on Python

Re: [libvirt] [PATCH] Fix syntax error on Python 3.7

On Wed, Jun 27, 2018 at 01:03:03PM +0200, Miro Hrončok wrote: > From 0d3b7cc9ba787a139ecbe6dac490b1f5bb021b7f Mon Sep 17 00:00:00 2001 > From: =?UTF-8?q?Miro=20Hron=C4=8Dok?= > Date: Wed, 27 Jun 2018 13:00:28 +0200 > Subject: [PATCH] Fix syntax error on Python 3.7 > > async is a keyword now. >

[libvirt] [PATCH] Fix syntax error on Python 3.7

From 0d3b7cc9ba787a139ecbe6dac490b1f5bb021b7f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Miro=20Hron=C4=8Dok?= Date: Wed, 27 Jun 2018 13:00:28 +0200 Subject: [PATCH] Fix syntax error on Python 3.7 async is a keyword now. `asyncio import ensure_future` works on Python 3.4 to 3.7 `from asyncio

Re: [libvirt] [PATCH] Fix indentation of virshAllocpagesPagesizeCompleter arguments.

On 05/24/2018 03:51 PM, Michal Privoznik wrote: > On 05/23/2018 04:08 PM, Roland Schulz wrote: >> --- >> tools/virsh-completer.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) > > This patch is missing SoB line. I cannot push this patch without it. Can > you please confirm here

Re: [libvirt] [PATCH] Fix indentation of virshAllocpagesPagesizeCompleter arguments.

On 05/23/2018 04:08 PM, Roland Schulz wrote: > --- > tools/virsh-completer.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) This patch is missing SoB line. I cannot push this patch without it. Can you please confirm here that I can add is there (funny, because your other patches

[libvirt] [PATCH] Fix indentation of virshAllocpagesPagesizeCompleter arguments.

--- tools/virsh-completer.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/virsh-completer.c b/tools/virsh-completer.c index cbd5326d0..1df4d55af 100644 --- a/tools/virsh-completer.c +++ b/tools/virsh-completer.c @@ -568,8 +568,8 @@

Re: [libvirt] [PATCH] Fix memory leak issues in virshAllocpagesPagesizeCompleter.

On 05/23/2018 02:40 PM, Roland Schulz wrote: > Signed-off-by: Roland Schulz > --- > tools/virsh-completer.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/tools/virsh-completer.c b/tools/virsh-completer.c > index 1435d1d4c..c72f3bcad

[libvirt] [PATCH] Fix memory leak issues in virshAllocpagesPagesizeCompleter.

Signed-off-by: Roland Schulz --- tools/virsh-completer.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tools/virsh-completer.c b/tools/virsh-completer.c index 1435d1d4c..c72f3bcad 100644 --- a/tools/virsh-completer.c +++

Re: [libvirt] [PATCH] Fix build with clang 6.0.0

Michal Privoznik wrote: > On 03/11/2018 04:38 PM, Roman Bogorodskiy wrote: > > Clang 6.0.0 complains when initializing structure with { NULL }: > > > > conf/domain_addr.c:1494:38: error: missing field 'type' initializer > > [-Werror,-Wmissing-field-initializers] > > virDomainDeviceInfo

Re: [libvirt] [PATCH] Fix build with clang 6.0.0

On 03/11/2018 04:38 PM, Roman Bogorodskiy wrote: > Clang 6.0.0 complains when initializing structure with { NULL }: > > conf/domain_addr.c:1494:38: error: missing field 'type' initializer > [-Werror,-Wmissing-field-initializers] > virDomainDeviceInfo nfo = { NULL }; > > Use { 0 } instead to

[libvirt] [PATCH] Fix build with clang 6.0.0

Clang 6.0.0 complains when initializing structure with { NULL }: conf/domain_addr.c:1494:38: error: missing field 'type' initializer [-Werror,-Wmissing-field-initializers] virDomainDeviceInfo nfo = { NULL }; Use { 0 } instead to make it happy. --- src/conf/domain_addr.c | 2 +-

[libvirt] [PATCH] Fix build with GCC 8 new switch fallthrough warnings

GCC 8 became more fussy about detecting switch fallthroughs. First it doesn't like it if you have a fallthrough attribute that is not before a case statement. e.g. FOO: BAR: WIZZ: ATTRIBUTE_FALLTHROUGH; Is unacceptable as there's no final case statement, so while FOO & BAR are

Re: [libvirt] [PATCH] Fix build with GCC 8 new warnings

On Tue, 2018-02-13 at 12:21 +, Daniel P. Berrangé wrote: > @@ -175,9 +175,9 @@ qemuDomainAsyncJobPhaseToString(qemuDomainAsyncJob job, > case QEMU_ASYNC_JOB_NONE: > case QEMU_ASYNC_JOB_LAST: > ATTRIBUTE_FALLTHROUGH; > +default: > +return "none"; > } > - > -

Re: [libvirt] [PATCH] Fix build with GCC 8 new warnings

On Tue, Feb 13, 2018 at 01:58:44PM +0100, Jiri Denemark wrote: > On Tue, Feb 13, 2018 at 12:21:11 +, Daniel P. Berrangé wrote: > > GCC 8 added a -Wcast-function-type warning to -Wextra by > > default. This complains if you try to explicitly cast > > one function signature to another function

Re: [libvirt] [PATCH] Fix build with GCC 8 new warnings

On Tue, Feb 13, 2018 at 12:21:11 +, Daniel P. Berrangé wrote: > GCC 8 added a -Wcast-function-type warning to -Wextra by > default. This complains if you try to explicitly cast > one function signature to another function signature > with incompatible args. This is something we do many > times

[libvirt] [PATCH] Fix build with GCC 8 new warnings

GCC 8 added a -Wcast-function-type warning to -Wextra by default. This complains if you try to explicitly cast one function signature to another function signature with incompatible args. This is something we do many times in libvirt especially with event callbacks. The hack to silence the warning

Re: [libvirt] [PATCH] fix regex to check CN from server certificate

On Fri, 2018-01-26 at 14:33 -0500, Tiago M. Vieira wrote: > Currently when the script validates the PKI files and > the certificate 'Subject:' field contains RDNs after > the Common Name (CN), these values are also included, > creating a false result that the CN is not correct. > > A small change

[libvirt] [PATCH] fix regex to check CN from server certificate

Currently when the script validates the PKI files and the certificate 'Subject:' field contains RDNs after the Common Name (CN), these values are also included, creating a false result that the CN is not correct. A small change to the sed regex fixes this issue, by extracting only the value for

Re: [libvirt] [PATCH] Fix minor typos (watchog, schedular)

On Sat, 2017-12-09 at 20:37 +0200, Yuri Chornoivan wrote: > Hi, > > Please find the attached patch for the following fixes > > watchog -> watchdog > schedular -> scheduler ACK to the changes. You missed one instance of the second typo in src/qemu/qemu.conf: I fixed that as well, squashed the

[libvirt] [PATCH] Fix minor typos (watchog, schedular)

Hi, Please find the attached patch for the following fixes watchog -> watchdog schedular -> scheduler Many thanks in advance for reviewing the fixes. Best regards, Yuri>From 4faf81231d4ace22932565119a8c59465c7f9b4e Mon Sep 17 00:00:00 2001 From: Yuri Chornoivan Date: Sat, 9

  1   2   3   4   5   6   7   8   9   10   >