Re: [libvirt] [PATCH] fix LSB part of virtlogd runlevel script

2015-12-02 Thread Martin Kletzander
On Wed, Dec 02, 2015 at 08:52:28AM +0100, Olaf Hering wrote: On Wed, Dec 02, Martin Kletzander wrote: But seeing this patch, we should also fix other init scripts, I believe. I, personally, see only the same problem in src/locking/virtlockd.init.in, but I didn't use the script you used.

Re: [libvirt] [PATCH] fix LSB part of virtlogd runlevel script

2015-12-01 Thread Olaf Hering
On Wed, Dec 02, Martin Kletzander wrote: > It must work without network, but it doesn't even have to be started > after network, so there is not even a weak dependency, IMO. Depending on how the daemon works (which I dont know) it may log to remote filesystems. So I think its safe to start it

Re: [libvirt] [PATCH] fix LSB part of virtlogd runlevel script

2015-12-01 Thread Olaf Hering
On Wed, Dec 02, Martin Kletzander wrote: > But seeing this patch, we should also fix other init scripts, I believe. > I, personally, see only the same problem in > src/locking/virtlockd.init.in, but I didn't use the script you used. virtlockd.init happens to work for me because there is a local

Re: [libvirt] [PATCH] fix LSB part of virtlogd runlevel script

2015-12-01 Thread Martin Kletzander
On Tue, Dec 01, 2015 at 02:09:59PM +, Olaf Hering wrote: Currently pkg build of master branch fails: [ 300s] + /usr/lib/rpm/brp-boot-scripts [ 300s] E: File `virtlogd' is missing `Required-Start', please add even if empty! [ 300s] W: File `virtlogd' is missing `Required-Stop', please

[libvirt] [PATCH] fix LSB part of virtlogd runlevel script

2015-12-01 Thread Olaf Hering
Currently pkg build of master branch fails: [ 300s] + /usr/lib/rpm/brp-boot-scripts [ 300s] E: File `virtlogd' is missing `Required-Start', please add even if empty! [ 300s] W: File `virtlogd' is missing `Required-Stop', please add even if empty! [ 300s] E: File `virtlogd' has empty