Re: [libvirt] [PATCH] fix virsh dominfo returns error when virNodeGetSecurityModel() is not supported.

2009-06-25 Thread Daniel Veillard
On Thu, Jun 25, 2009 at 09:29:48AM +0900, Tatsuro Enokura wrote: Hi Dan, Tatsuro Enokura wrote: I don't think that is neccessary. You'll only invoke virDomainGetSecurityLabel if virNodeGetSecurityModel() was asuccessfull and the returned secmodel is not the empty string. In such a scenario

Re: [libvirt] [PATCH] fix virsh dominfo returns error when virNodeGetSecurityModel() is not supported.

2009-06-25 Thread Daniel P. Berrange
On Thu, Jun 25, 2009 at 03:43:12PM +0200, Daniel Veillard wrote: On Thu, Jun 25, 2009 at 09:29:48AM +0900, Tatsuro Enokura wrote: Hi Dan, Tatsuro Enokura wrote: I don't think that is neccessary. You'll only invoke virDomainGetSecurityLabel if virNodeGetSecurityModel() was asuccessfull

Re: [libvirt] [PATCH] fix virsh dominfo returns error when virNodeGetSecurityModel() is not supported.

2009-06-24 Thread Tatsuro Enokura
Hi Dan, Tatsuro Enokura wrote: I don't think that is neccessary. You'll only invoke virDomainGetSecurityLabel if virNodeGetSecurityModel() was asuccessfull and the returned secmodel is not the empty string. In such a scenario I'd expect the call to virDomainGetSecurityLabel() to always be

Re: [libvirt] [PATCH] fix virsh dominfo returns error when virNodeGetSecurityModel() is not supported.

2009-06-21 Thread Tatsuro Enokura
Hi Dan, Daniel P. Berrange wrote: Index: src/virsh.c === RCS file: /data/cvs/libvirt/src/virsh.c,v retrieving revision 1.210 diff -u -p -u -r1.210 virsh.c --- src/virsh.c 3 Jun 2009 12:13:52 - 1.210 +++ src/virsh.c 18 Jun

Re: [libvirt] [PATCH] fix virsh dominfo returns error when virNodeGetSecurityModel() is not supported.

2009-06-19 Thread Daniel P. Berrange
On Fri, Jun 19, 2009 at 10:58:18AM +0900, Tatsuro Enokura wrote: Hi Dan, Daniel P. Berrange wrote: The explanation of virNodeGetSecurityModel() and virNodeGetSecurityModel() in libvirt.c is return -2 when hypervisor drivers don't support these operations. But these functions return -1 in

Re: [libvirt] [PATCH] fix virsh dominfo returns error when virNodeGetSecurityModel() is not supported.

2009-06-19 Thread Daniel Veillard
On Thu, Jun 18, 2009 at 12:20:16PM +0100, Daniel P. Berrange wrote: On Thu, Jun 18, 2009 at 06:08:36PM +0900, Tatsuro Enokura wrote: Hi all I try virsh dominfo in upstream libvirt on xen machine, the commands returns -1 as follows: Opps, thanks for reporting this problem - surprised

[libvirt] [PATCH] fix virsh dominfo returns error when virNodeGetSecurityModel() is not supported.

2009-06-18 Thread Tatsuro Enokura
Hi all I try virsh dominfo in upstream libvirt on xen machine, the commands returns -1 as follows: [r...@vmi20 ~]# virsh dominfo rhel53rc2_pv_sdb3 Id: 1 Name: rhel53rc2_pv_sdb3 UUID: 05ba9be8-f4e9-e208-11c7-fc936655cd8e OS Type:linux State: idle

Re: [libvirt] [PATCH] fix virsh dominfo returns error when virNodeGetSecurityModel() is not supported.

2009-06-18 Thread Tatsuro Enokura
Hi Dan, Daniel P. Berrange wrote: The explanation of virNodeGetSecurityModel() and virNodeGetSecurityModel() in libvirt.c is return -2 when hypervisor drivers don't support these operations. But these functions return -1 in this case, and so cmdDominfo() in virsh.c returns FALSE. This API