Re: [libvirt] [PATCH] fs: Fix pool building when directory already exists

2015-07-17 Thread Christophe Fergeau
On Fri, Jul 17, 2015 at 10:31:11AM +0200, Martin Kletzander wrote: > On Fri, Jul 17, 2015 at 10:12:44AM +0200, Christophe Fergeau wrote: > >Currently, when trying to virsh pool-define/virsh pool-build a new > >'dir' pool, if the target directory already exists, virsh > >pool-build/virStoragePoolBui

Re: [libvirt] [PATCH] fs: Fix pool building when directory already exists

2015-07-17 Thread Martin Kletzander
On Fri, Jul 17, 2015 at 10:12:44AM +0200, Christophe Fergeau wrote: Currently, when trying to virsh pool-define/virsh pool-build a new 'dir' pool, if the target directory already exists, virsh pool-build/virStoragePoolBuild will error out. This is a change of behaviour compared to eg libvirt 1.2.

[libvirt] [PATCH] fs: Fix pool building when directory already exists

2015-07-17 Thread Christophe Fergeau
Currently, when trying to virsh pool-define/virsh pool-build a new 'dir' pool, if the target directory already exists, virsh pool-build/virStoragePoolBuild will error out. This is a change of behaviour compared to eg libvirt 1.2.13 This is caused by the wrong type being used for the dir_create_fla