Re: [libvirt] [PATCH] hash: add common utility functions

2014-04-07 Thread Eric Blake
On 04/07/2014 03:23 AM, Peter Krempa wrote: > On 04/05/14 01:49, Eric Blake wrote: >> I almost wrote a hash value free function that just called >> VIR_FREE, then realized I couldn't be the first person to >> do that. Sure enough, it was worth factoring into a common >> helper routine. >> > > AC

Re: [libvirt] [PATCH] hash: add common utility functions

2014-04-07 Thread Peter Krempa
On 04/05/14 01:49, Eric Blake wrote: > I almost wrote a hash value free function that just called > VIR_FREE, then realized I couldn't be the first person to > do that. Sure enough, it was worth factoring into a common > helper routine. > > Furthermore, in a few places we were passing raw free()

[libvirt] [PATCH] hash: add common utility functions

2014-04-04 Thread Eric Blake
I almost wrote a hash value free function that just called VIR_FREE, then realized I couldn't be the first person to do that. Sure enough, it was worth factoring into a common helper routine. Furthermore, in a few places we were passing raw free() as the cleanup function; whereas going through VI