Re: [libvirt] [PATCH] hash: make virHashFree more free-like

2011-02-21 Thread Eric Blake
On 02/18/2011 02:49 PM, Laine Stump wrote: On 02/18/2011 04:31 PM, Eric Blake wrote: Two-argument free functions are uncommon; match the style elsewhere by caching the callback at creation. ACK. Pretty mechanical conversion, and a great idea! Thanks; applied. -- Eric Blake

[libvirt] [PATCH] hash: make virHashFree more free-like

2011-02-18 Thread Eric Blake
Two-argument free functions are uncommon; match the style elsewhere by caching the callback at creation. * src/util/hash.h (virHashCreate, virHashFree): Move deallocator argument to creation. * cfg.mk (useless_free_options): Add virHashFree. * src/util/hash.c (_virHashTable): Track deallocator.

Re: [libvirt] [PATCH] hash: make virHashFree more free-like

2011-02-18 Thread Laine Stump
On 02/18/2011 04:31 PM, Eric Blake wrote: Two-argument free functions are uncommon; match the style elsewhere by caching the callback at creation. * src/util/hash.h (virHashCreate, virHashFree): Move deallocator argument to creation. * cfg.mk (useless_free_options): Add virHashFree. *