Re: [libvirt] [PATCH] hostdev: fix two bugs in virHostdevReAttachPCIDevices

2015-03-25 Thread Huanle Han
I'm sorry that I didn't configure the 'git send-email' well. The 2 issues can be consider separate. Issue 1(move the 'i++'): Yes, I do mean that we shouldn't update the 'i' value for the reason you said. I was thinking to minimize the change. But while loop is also a good choose. Issue 2: Steps

Re: [libvirt] [PATCH] hostdev: fix two bugs in virHostdevReAttachPCIDevices

2015-03-24 Thread John Ferlan
On 03/22/2015 09:59 AM, Huanle Han wrote: Bug 1: The the next element in the pcidevs is skipped after we virPCIDeviceListDel the previous element. Bug 2: virHostdevNetConfigRestore is called for store the hostdevs which may be used by other domain. Signed-off-by: Huanle Han

[libvirt] [PATCH] hostdev: fix two bugs in virHostdevReAttachPCIDevices

2015-03-23 Thread Huanle Han
Bug 1: The the next element in the pcidevs is skipped after we virPCIDeviceListDel the previous element. Bug 2: virHostdevNetConfigRestore is called for store the hostdevs which may be used by other domain. Signed-off-by: Huanle Han hanxue...@gmail.com --- src/util/virhostdev.c | 25