Re: [libvirt] [PATCH] i18n: simplify mini po generation

2019-05-21 Thread Daniel P . Berrangé
On Mon, May 20, 2019 at 02:59:27PM -0500, Marty E. Plummer wrote: > On Mon, May 20, 2019 at 10:14:32AM +0100, Daniel P. Berrangé wrote: > > On Sat, May 18, 2019 at 10:56:01AM -0500, Marty E. Plummer wrote: > > > If you pass --for-msgfmt to msgmerge it will automatically do most of > > > what you ha

Re: [libvirt] [PATCH] i18n: simplify mini po generation

2019-05-20 Thread Marty E. Plummer
On Mon, May 20, 2019 at 10:14:32AM +0100, Daniel P. Berrangé wrote: > On Sat, May 18, 2019 at 10:56:01AM -0500, Marty E. Plummer wrote: > > If you pass --for-msgfmt to msgmerge it will automatically do most of > > what you had the perl script doing. > > What msgmerge are you using as that option d

Re: [libvirt] [PATCH] i18n: simplify mini po generation

2019-05-20 Thread Daniel P . Berrangé
On Sat, May 18, 2019 at 10:56:01AM -0500, Marty E. Plummer wrote: > If you pass --for-msgfmt to msgmerge it will automatically do most of > what you had the perl script doing. What msgmerge are you using as that option doesn't exist on Fedora 30 at least ? $ msgmerge --for-msgfmt --sort-output

[libvirt] [PATCH] i18n: simplify mini po generation

2019-05-20 Thread Marty E. Plummer
If you pass --for-msgfmt to msgmerge it will automatically do most of what you had the perl script doing. Signed-off-by: Marty E. Plummer --- The only downside I can see is the loss of the comment headers with the copyright year and such. A global note in the README.md or so may be an acceptable