Re: [libvirt] [PATCH] interface: Check for interface (in-)activity on some operations

2011-07-18 Thread Laine Stump
On 07/15/2011 10:36 AM, Michal Privoznik wrote: On 15.07.2011 16:29, Eric Blake wrote: On 07/15/2011 07:58 AM, Michal Privoznik wrote: Right now it is possible to undefine an active interface, or destroy inactive. This patch add some checking to these operations to prevent this. Also fix test

[libvirt] [PATCH] interface: Check for interface (in-)activity on some operations

2011-07-15 Thread Michal Privoznik
Right now it is possible to undefine an active interface, or destroy inactive. This patch add some checking to these operations to prevent this. Also fix test driver. --- src/interface/netcf_driver.c | 83 -- src/test/test_driver.c |5 +++ 2

Re: [libvirt] [PATCH] interface: Check for interface (in-)activity on some operations

2011-07-15 Thread Eric Blake
On 07/15/2011 07:58 AM, Michal Privoznik wrote: Right now it is possible to undefine an active interface, or destroy inactive. This patch add some checking to these operations to prevent this. Also fix test driver. I'm inclined to NACK this on design principles (I haven't read the patch

Re: [libvirt] [PATCH] interface: Check for interface (in-)activity on some operations

2011-07-15 Thread Michal Privoznik
On 15.07.2011 16:29, Eric Blake wrote: On 07/15/2011 07:58 AM, Michal Privoznik wrote: Right now it is possible to undefine an active interface, or destroy inactive. This patch add some checking to these operations to prevent this. Also fix test driver. I'm inclined to NACK this on design

Re: [libvirt] [PATCH] interface: Check for interface (in-)activity on some operations

2011-07-15 Thread Michal Privoznik
On 15.07.2011 16:45, Eric Blake wrote: On 07/15/2011 08:36 AM, Michal Privoznik wrote: On the other hand, if we don't support transient interfaces, then the above analysis which works for domains would have to be adjusted for interfaces, so you may have something to patch after all. Well,

Re: [libvirt] [PATCH] interface: Check for interface (in-)activity on some operations

2011-07-15 Thread Eric Blake
On 07/15/2011 08:45 AM, Eric Blake wrote: On 07/15/2011 08:36 AM, Michal Privoznik wrote: On the other hand, if we don't support transient interfaces, then the above analysis which works for domains would have to be adjusted for interfaces, so you may have something to patch after all. Well,

Re: [libvirt] [PATCH] interface: Check for interface (in-)activity on some operations

2011-07-15 Thread Eric Blake
On 07/15/2011 08:48 AM, Michal Privoznik wrote: On 15.07.2011 16:45, Eric Blake wrote: On 07/15/2011 08:36 AM, Michal Privoznik wrote: On the other hand, if we don't support transient interfaces, then the above analysis which works for domains would have to be adjusted for interfaces, so you

Re: [libvirt] [PATCH] interface: Check for interface (in-)activity on some operations

2011-07-15 Thread Matthias Bolte
2011/7/15 Eric Blake ebl...@redhat.com: On 07/15/2011 08:45 AM, Eric Blake wrote: On 07/15/2011 08:36 AM, Michal Privoznik wrote: On the other hand, if we don't support transient interfaces, then the above analysis which works for domains would have to be adjusted for interfaces, so you may

Re: [libvirt] [PATCH] interface: Check for interface (in-)activity on some operations

2011-07-15 Thread Matthias Bolte
2011/7/15 Eric Blake ebl...@redhat.com: On 07/15/2011 08:48 AM, Michal Privoznik wrote: On 15.07.2011 16:45, Eric Blake wrote: On 07/15/2011 08:36 AM, Michal Privoznik wrote: On the other hand, if we don't support transient interfaces, then the above analysis which works for domains would