[libvirt] [PATCH] leaseshelper: add enhancements to support all events

2014-07-10 Thread Nehal J Wani
This patch enables the helper program to detect event(s) triggered when there is a change in lease length or expiry and client-id. This transfers complete control of leases database to libvirt and suppresses use of the lease database file (.leases). That file will not be created, read, or written.

Re: [libvirt] [PATCH] leaseshelper: add enhancements to support all events

2014-07-16 Thread Nehal J Wani
On Fri, Jul 11, 2014 at 5:49 AM, Nehal J Wani wrote: > This patch enables the helper program to detect event(s) triggered when there > is a change in lease length or expiry and client-id. This transfers complete > control of leases database to libvirt and suppresses use of the lease database > fil

Re: [libvirt] [PATCH] leaseshelper: add enhancements to support all events

2014-07-16 Thread Peter Krempa
On 07/11/14 02:19, Nehal J Wani wrote:> This patch enables the helper program to detect event(s) triggered when there > is a change in lease length or expiry and client-id. This transfers complete > control of leases database to libvirt and suppresses use of the lease database > file (.leases). Tha

Re: [libvirt] [PATCH] leaseshelper: add enhancements to support all events

2014-07-16 Thread Nehal J Wani
>> cmd = virCommandNew(dnsmasqCapsGetBinaryPath(caps)); >> virCommandAddArgFormat(cmd, "--conf-file=%s", configfile); >> -virCommandAddArgFormat(cmd, "--dhcp-script=%s", leaseshelper_path); >> +virCommandAddArgFormat(cmd, "--dhcp-script=%s", >> pseudo_leaseshelper_path); >> +

Re: [libvirt] [PATCH] leaseshelper: add enhancements to support all events

2014-07-17 Thread Peter Krempa
On 07/16/14 17:31, Nehal J Wani wrote: >>> cmd = virCommandNew(dnsmasqCapsGetBinaryPath(caps)); >>> virCommandAddArgFormat(cmd, "--conf-file=%s", configfile); >>> -virCommandAddArgFormat(cmd, "--dhcp-script=%s", leaseshelper_path); >>> +virCommandAddArgFormat(cmd, "--dhcp-script=%

Re: [libvirt] [PATCH] leaseshelper: add enhancements to support all events

2014-07-17 Thread Nehal J Wani
> My concerns are whether this will work in the case you already used the > leases helper as the patch is adding a few fields to the stored format. In this patch, I am only adding server-duid as an extra JSON object. I am not adding more fields to an existing JSON object. The old leases file will

Re: [libvirt] [PATCH] leaseshelper: add enhancements to support all events

2014-07-17 Thread Eric Blake
On 07/17/2014 09:18 AM, Peter Krempa wrote: >>> A second issue that comes into my mind is compatibility with already >>> existing files. Does this work when you already have a lease file? (I >>> didn't try it, I'm just asking). >> >> If we use the --leasefile-ro option, then although this method w

Re: [libvirt] [PATCH] leaseshelper: add enhancements to support all events

2014-07-21 Thread Nehal J Wani
On Thu, Jul 17, 2014 at 9:38 PM, Eric Blake wrote: > On 07/17/2014 09:18 AM, Peter Krempa wrote: > A second issue that comes into my mind is compatibility with already existing files. Does this work when you already have a lease file? (I didn't try it, I'm just asking). >>> >>> If w

Re: [libvirt] [PATCH] leaseshelper: add enhancements to support all events

2014-07-11 Thread Nehal J Wani
On Fri, Jul 11, 2014 at 5:49 AM, Nehal J Wani wrote: > This patch enables the helper program to detect event(s) triggered when there > is a change in lease length or expiry and client-id. This transfers complete > control of leases database to libvirt and suppresses use of the lease database > fil