Re: [libvirt] [PATCH] libvirt: virsh: Kill all uses of __FUNCTION__ in error messages

2015-04-04 Thread Noella Ashu
Thanks Michal, I will look at another introductory bug to work on. Any suggestions will help. Thanks, Noella On Fri, Apr 3, 2015 at 1:13 PM, Michal Privoznik mpriv...@redhat.com wrote: On 03.04.2015 12:33, Noella Ashu wrote: The error output of snapshot-revert should be more friendly. There

Re: [libvirt] [PATCH] libvirt: virsh: Kill all uses of __FUNCTION__ in error messages

2015-04-03 Thread Noella Ashu
insertions(+), 135 deletions(-) I'm having some difficulties applying this patch: Applying: libvirt: virsh: Kill all uses of __FUNCTION__ in error messages /home/zippy/work/libvirt/libvirt.git/.git/rebase-apply/patch:91: trailing whitespace. virReportInvalidArg(stream, %s, /home/zippy/work

[libvirt] [PATCH] libvirt: virsh: Kill all uses of __FUNCTION__ in error messages

2015-04-03 Thread Noella Ashu
The error output of snapshot-revert should be more friendly. There is no need to show up virDomainRevertToSnapshot to user. virError already includes __FUNCTION__ information in a separate member of the struct, so repeating it in the message is redundant and leads to situations where higher level

Re: [libvirt] [PATCH] libvirt: virsh: Kill all uses of __FUNCTION__ in error messages

2015-04-03 Thread Michal Privoznik
On 03.04.2015 12:33, Noella Ashu wrote: The error output of snapshot-revert should be more friendly. There is no need to show up virDomainRevertToSnapshot to user. virError already includes __FUNCTION__ information in a separate member of the struct, so repeating it in the message is

Re: [libvirt] [PATCH] libvirt: virsh: Kill all uses of __FUNCTION__ in error messages

2015-04-03 Thread Michal Privoznik
/libvirt-domain.c | 201 ++ 2 files changed, 96 insertions(+), 135 deletions(-) I'm having some difficulties applying this patch: Applying: libvirt: virsh: Kill all uses of __FUNCTION__ in error messages /home/zippy/work/libvirt/libvirt.git/.git

Re: [libvirt] [PATCH] libvirt: virsh: Kill all uses of __FUNCTION__ in error messages

2015-04-03 Thread Noella Ashu
(-) I'm having some difficulties applying this patch: Applying: libvirt: virsh: Kill all uses of __FUNCTION__ in error messages /home/zippy/work/libvirt/libvirt.git/.git/rebase-apply/patch:91: trailing whitespace. virReportInvalidArg(stream, %s, /home/zippy/work/libvirt/libvirt.git/.git

[libvirt] [PATCH] libvirt: virsh: Kill all uses of __FUNCTION__ in error messages

2015-04-01 Thread Noella Ashu
The error output of snapshot-revert should be more friendly. There is no need to show up virDomainRevertToSnapshot to user. virError already includes __FUNCTION__ information in a separate member of the struct, so repeating it in the message is redundant and leads to situations where higher level