Re: [libvirt] [PATCH] libvirt-domain.h: Fix enum description placement

2017-07-21 Thread Daniel P. Berrange
On Fri, Jul 21, 2017 at 04:33:06PM +0200, Jiri Denemark wrote: > On Fri, Jul 21, 2017 at 14:42:05 +0100, Daniel P. Berrange wrote: > > On Fri, Jul 21, 2017 at 03:00:20PM +0200, Martin Kletzander wrote: > > > > struct meh { > > > /*# This is comment for the following member foo */ > > >

Re: [libvirt] [PATCH] libvirt-domain.h: Fix enum description placement

2017-07-21 Thread Martin Kletzander
On Fri, Jul 21, 2017 at 02:42:05PM +0100, Daniel P. Berrange wrote: On Fri, Jul 21, 2017 at 03:00:20PM +0200, Martin Kletzander wrote: On Fri, Jul 21, 2017 at 11:58:45AM +0100, Daniel P. Berrange wrote: > On Fri, Jul 21, 2017 at 12:52:06PM +0200, Michal Privoznik wrote: > > There are only two

Re: [libvirt] [PATCH] libvirt-domain.h: Fix enum description placement

2017-07-21 Thread Jiri Denemark
On Fri, Jul 21, 2017 at 14:42:05 +0100, Daniel P. Berrange wrote: > On Fri, Jul 21, 2017 at 03:00:20PM +0200, Martin Kletzander wrote: > > struct meh { > > /*# This is comment for the following member foo */ > > unsigned int foo; > > int bar; /*< This is for member bar that's on

Re: [libvirt] [PATCH] libvirt-domain.h: Fix enum description placement

2017-07-21 Thread Daniel P. Berrange
On Fri, Jul 21, 2017 at 03:00:20PM +0200, Martin Kletzander wrote: > On Fri, Jul 21, 2017 at 11:58:45AM +0100, Daniel P. Berrange wrote: > > On Fri, Jul 21, 2017 at 12:52:06PM +0200, Michal Privoznik wrote: > > > There are only two acceptable places for describing enum values. > > > It's either: >

Re: [libvirt] [PATCH] libvirt-domain.h: Fix enum description placement

2017-07-21 Thread Martin Kletzander
On Fri, Jul 21, 2017 at 11:58:45AM +0100, Daniel P. Berrange wrote: On Fri, Jul 21, 2017 at 12:52:06PM +0200, Michal Privoznik wrote: There are only two acceptable places for describing enum values. It's either: typedef enum { /* Some long description. Therefore it's placed before

Re: [libvirt] [PATCH] libvirt-domain.h: Fix enum description placement

2017-07-21 Thread Daniel P. Berrange
On Fri, Jul 21, 2017 at 12:52:06PM +0200, Michal Privoznik wrote: > There are only two acceptable places for describing enum values. > It's either: > > typedef enum { > /* Some long description. Therefore it's placed before > * the value. */ > VIR_ENUM_A_VAL = 1, >

[libvirt] [PATCH] libvirt-domain.h: Fix enum description placement

2017-07-21 Thread Michal Privoznik
There are only two acceptable places for describing enum values. It's either: typedef enum { /* Some long description. Therefore it's placed before * the value. */ VIR_ENUM_A_VAL = 1, } virEnumA; or: typedef enum { VIR_ENUM_B_VAL = 1, /* Some short