Re: [libvirt] [PATCH] libvirt-guests: avoid globbing when splitting $URIS

2011-03-14 Thread Philipp Hahn
Hello Eric, Am Freitag 11 März 2011 22:08:33 schrieb Eric Blake: * tools/libvirt-guests.init.sh (start, stop, gueststatus): Avoid shell globbing, since valid URIs can contain '?'. Looks sane, but perhaps setting 'set -f' once at the top of the file with some comment would fix the problem as

Re: [libvirt] [PATCH] libvirt-guests: avoid globbing when splitting $URIS

2011-03-14 Thread Eric Blake
On 03/14/2011 01:37 AM, Philipp Hahn wrote: Hello Eric, Am Freitag 11 März 2011 22:08:33 schrieb Eric Blake: * tools/libvirt-guests.init.sh (start, stop, gueststatus): Avoid shell globbing, since valid URIs can contain '?'. Looks sane, but perhaps setting 'set -f' once at the top of the

[libvirt] [PATCH] libvirt-guests: avoid globbing when splitting $URIS

2011-03-11 Thread Eric Blake
* tools/libvirt-guests.init.sh (start, stop, gueststatus): Avoid shell globbing, since valid URIs can contain '?'. --- Meanwhile, we already know that a valid URI does not contain whitespace (a valid URI can represent whitespace via encoding, where needed), so it's already acceptable to use