On 19.09.2014 05:01, Jim Fehlig wrote:
> Stefan Bader wrote:
>> Re-pushing this as the old thread got rather stale.
>
> Thanks.
>
>> Some of the
>> VFB setup went in a bug fix. Not sure I missed a detail in rebasing
>> bug the keyboard setting may be the only thing missing...
>>
>
> Yes, agr
Stefan Bader wrote:
> Re-pushing this as the old thread got rather stale.
Thanks.
> Some of the
> VFB setup went in a bug fix. Not sure I missed a detail in rebasing
> bug the keyboard setting may be the only thing missing...
>
Yes, agreed.
> -Stefan
>
> [v2: Check return code of VIR_STRDUP
Re-pushing this as the old thread got rather stale. Some of the
VFB setup went in a bug fix. Not sure I missed a detail in rebasing
bug the keyboard setting may be the only thing missing...
-Stefan
[v2: Check return code of VIR_STRDUP and fix indentation]
[v3: Split out VRAM fixup and return erro
Stefan Bader wrote:
> On 16.07.2014 23:05, Jim Fehlig wrote:
>
>> While testing this, I noticed that libvirt will set vram to 9216 if not
>> specified. E.g.
>>
>> # cat test.xml
>> ...
>>
>>
>>
>> ...
>> # virsh define test.xml
>> # virsh dumpxml test
>> ...
>>
>>
>
On 16.07.2014 23:05, Jim Fehlig wrote:
> Stefan Bader wrote:
>> being as bad with timely responses. Ok, so how about the following?
>>
>> One note: it could be the STRDUP's are not strictly needed. But
>> to me it felt wrong to have two places refer to the same strings
>> (as MakeVFB copies the str
On 07/16/2014 03:05 PM, Jim Fehlig wrote:
>> +b_info->video_memkb = def->videos[0]->vram ?
>> + def->videos[0]->vram :
>> + LIBXL_MEMKB_DEFAULT;
>>
>
> While testing this, I noticed that libvirt will set vram to 9216 if not
> sp
Stefan Bader wrote:
> being as bad with timely responses. Ok, so how about the following?
>
> One note: it could be the STRDUP's are not strictly needed. But
> to me it felt wrong to have two places refer to the same strings
> (as MakeVFB copies the struct containing the pointers).
Agreed. Withou
being as bad with timely responses. Ok, so how about the following?
One note: it could be the STRDUP's are not strictly needed. But
to me it felt wrong to have two places refer to the same strings
(as MakeVFB copies the struct containing the pointers). If this
is not needed, then all changes now i
