Re: [libvirt] [PATCH] libxl: avoid crashing if calling `virsh numatune' on inactive domain

2013-12-28 Thread Doug Goldstein
On Sat, Dec 28, 2013 at 3:18 PM, Doug Goldstein wrote: > On Tue, Dec 24, 2013 at 12:02 AM, Eric Blake wrote: >> On 12/20/2013 11:36 AM, Jim Fehlig wrote: >>> Dario Faggioli wrote: by, in libxlDomainGetNumaParameters(), calling libxl_bitmap_init() as soon as possible, which avoids

Re: [libvirt] [PATCH] libxl: avoid crashing if calling `virsh numatune' on inactive domain

2013-12-28 Thread Doug Goldstein
On Tue, Dec 24, 2013 at 12:02 AM, Eric Blake wrote: > On 12/20/2013 11:36 AM, Jim Fehlig wrote: >> Dario Faggioli wrote: >>> by, in libxlDomainGetNumaParameters(), calling libxl_bitmap_init() as soon >>> as >>> possible, which avoids getting to 'cleanup:', where libxl_bitmap_dispose() >>> happens

Re: [libvirt] [PATCH] libxl: avoid crashing if calling `virsh numatune' on inactive domain

2013-12-23 Thread Eric Blake
On 12/20/2013 11:36 AM, Jim Fehlig wrote: > Dario Faggioli wrote: >> by, in libxlDomainGetNumaParameters(), calling libxl_bitmap_init() as soon as >> possible, which avoids getting to 'cleanup:', where libxl_bitmap_dispose() >> happens, without having initialized the nodemap, and hence crashing aft

Re: [libvirt] [PATCH] libxl: avoid crashing if calling `virsh numatune' on inactive domain

2013-12-20 Thread Jim Fehlig
Dario Faggioli wrote: > by, in libxlDomainGetNumaParameters(), calling libxl_bitmap_init() as soon as > possible, which avoids getting to 'cleanup:', where libxl_bitmap_dispose() > happens, without having initialized the nodemap, and hence crashing after some > invalid free()-s: > Yikes! ACK t

[libvirt] [PATCH] libxl: avoid crashing if calling `virsh numatune' on inactive domain

2013-12-20 Thread Dario Faggioli
by, in libxlDomainGetNumaParameters(), calling libxl_bitmap_init() as soon as possible, which avoids getting to 'cleanup:', where libxl_bitmap_dispose() happens, without having initialized the nodemap, and hence crashing after some invalid free()-s: # ./daemon/libvirtd -v *** Error in `/home/xen