Re: [libvirt] [PATCH] libxl: fix regression introduced by commit 4ab8cd77

2015-03-16 Thread Daniel P. Berrange
On Fri, Mar 13, 2015 at 06:38:24PM -0600, Jim Fehlig wrote: Commit 4ab8cd77 added a check requiring input devices to have a bus type of VIR_DOMAIN_INPUT_BUS_USB, failing to start the domain otherwise. But virDomainDefParseXML adds implicit mouse and keyboard if a graphics device is

Re: [libvirt] [PATCH] libxl: fix regression introduced by commit 4ab8cd77

2015-03-16 Thread Jim Fehlig
Daniel P. Berrange wrote: On Fri, Mar 13, 2015 at 06:38:24PM -0600, Jim Fehlig wrote: Commit 4ab8cd77 added a check requiring input devices to have a bus type of VIR_DOMAIN_INPUT_BUS_USB, failing to start the domain otherwise. But virDomainDefParseXML adds implicit mouse and keyboard if

[libvirt] [PATCH] libxl: fix regression introduced by commit 4ab8cd77

2015-03-13 Thread Jim Fehlig
Commit 4ab8cd77 added a check requiring input devices to have a bus type of VIR_DOMAIN_INPUT_BUS_USB, failing to start the domain otherwise. But virDomainDefParseXML adds implicit mouse and keyboard if a graphics device is configured. See calls to virDomainDefMaybeAddInput. The regression is