On 08/16/2013 05:46 PM, Jim Fehlig wrote:
From: Dario Faggioli dario.faggi...@citrix.com
...snip...
+
+ cleanup:
+if (ret != 0) {
+for (i = 0; i nr_nodes; i++)
+VIR_FREE(cpus[i]);
+virCapabilitiesFreeNUMAInfo(caps);
+}
+
Coverity got grumpy with
On 08/20/2013 11:01 AM, John Ferlan wrote:
The following resolves Coverity's complaint and keeps things safer:
-for (i = 0; i nr_nodes; i++)
+for (i = 0; cpus i nr_nodes; i++)
Pre-approved ACK if you want to work that into a formal patch.
--
Eric Blake eblake
On Fri, Aug 16, 2013 at 03:46:29PM -0600, Jim Fehlig wrote:
static int
+libxlCapsInitNuma(libxl_ctx *ctx, virCapsPtr caps)
+{
+libxl_numainfo *numa_info = NULL;
+libxl_cputopology *cpu_topo = NULL;
+int nr_nodes = 0, nr_cpus = 0;
+virCapsHostNUMACellCPUPtr *cpus = NULL;
+
Daniel P. Berrange wrote:
On Fri, Aug 16, 2013 at 03:46:29PM -0600, Jim Fehlig wrote:
static int
+libxlCapsInitNuma(libxl_ctx *ctx, virCapsPtr caps)
+{
+libxl_numainfo *numa_info = NULL;
+libxl_cputopology *cpu_topo = NULL;
+int nr_nodes = 0, nr_cpus = 0;
+
From: Dario Faggioli dario.faggi...@citrix.com
Starting from Xen 4.2, libxl has all the bits and pieces in place
for retrieving an adequate amount of information about the host
NUMA topology. It is therefore possible, after a bit of shuffling,
to arrange those information in the way libvirt wants
