Re: [libvirt] [PATCH] lxc: Fix reboot via initctl

2019-07-04 Thread Daniel P . Berrangé
On Thu, Jul 04, 2019 at 11:04:15AM +0200, Lubomir Rintel wrote: > virInitctlSetRunLevel() returns 0 only if ended up doing nothing, 1 if it > actually succeeded. Let's check for the error condition. > > Without this, a successful reboot would be treated as a failure and the > LXC driver will

[libvirt] [PATCH] lxc: Fix reboot via initctl

2019-07-04 Thread Lubomir Rintel
virInitctlSetRunLevel() returns 0 only if ended up doing nothing, 1 if it actually succeeded. Let's check for the error condition. Without this, a successful reboot would be treated as a failure and the LXC driver will proceed sending a TERM signal instead, effectively cancelling the shutdown.