[libvirt] [PATCH] mac os x: don't compile failing example program on 32 bit mac os x

2010-09-28 Thread Justin Clift
This addresses a compilation failure issue reported last year on OS X: https://www.redhat.com/archives/libvir-list/2009-May/msg00166.html In testing here, the compilation only fails on 32 bit OS X, but works on 64 bit, even when using exact same compile and linking flags. This commit

Re: [libvirt] [PATCH] mac os x: don't compile failing example program on 32 bit mac os x

2010-09-28 Thread Eric Blake
[adding bug-gnulib] On 09/28/2010 06:36 AM, Justin Clift wrote: This addresses a compilation failure issue reported last year on OS X: https://www.redhat.com/archives/libvir-list/2009-May/msg00166.html which in turn mentions: gcc -Wall -Wformat -Wmissing-prototypes -Wnested-externs

Re: [libvirt] [PATCH] mac os x: don't compile failing example program on 32 bit mac os x

2010-09-28 Thread Eric Blake
[replies can omit bug-gnulib] On 09/28/2010 08:29 AM, Eric Blake wrote: [adding bug-gnulib] which in turn mentions: gcc -Wall -Wformat -Wmissing-prototypes -Wnested-externs -Wpointer- arith -Wextra -Wshadow -Wcast-align -Wwrite-strings -Waggregate-return -Wstrict-prototypes -Winline

Re: [libvirt] [PATCH] mac os x: don't compile failing example program on 32 bit mac os x

2010-09-28 Thread Justin Clift
On 09/29/2010 12:29 AM, Eric Blake wrote: snip But the failed link mentions rpl_poll, not poll, which means this is most likely a gnulib bug in the poll module. Rather than skipping this test on just 32-bit MacOS in libvirt, I think the better thing to do is address why gnulib is triggering a