Re: [libvirt] [PATCH] maint: avoid potential promotion issues with [ug]id_t

2013-01-08 Thread Eric Blake
On 01/07/2013 08:12 PM, Guannan Ren wrote: >> * src/locking/lock_driver_sanlock.c >> (virLockManagerSanlockSetupLockspace, virLockManagerSanlockInit) >> (virLockManagerSanlockCreateLease): Cast -1 to proper type before >> comparing with uid_t or gid_t. > > According to GUN C library > "ui

Re: [libvirt] [PATCH] maint: avoid potential promotion issues with [ug]id_t

2013-01-07 Thread Guannan Ren
On 01/08/2013 07:06 AM, Eric Blake wrote: POSIX does not guarantee whether uid_t and gid_t are signed or unsigned, nor does it guarantee whether they are smaller, same size, or larger than int (or even the same size as one another). Therefore, it is possible to have platforms where '(uid_t)-1==-1

[libvirt] [PATCH] maint: avoid potential promotion issues with [ug]id_t

2013-01-07 Thread Eric Blake
POSIX does not guarantee whether uid_t and gid_t are signed or unsigned, nor does it guarantee whether they are smaller, same size, or larger than int (or even the same size as one another). Therefore, it is possible to have platforms where '(uid_t)-1==-1' is false or where 'uid = gid = -1' sets ui