Re: [libvirt] [PATCH] maint: make syntax-check default to a no-op on maint branches

2013-10-10 Thread Laine Stump
On 10/09/2013 04:10 PM, Daniel P. Berrange wrote: We should absolutely be running syntax-check as normal to identify that on -maint branches just as on master. IMHO all we want todo is add: local-checks-to-skip += sc_copyright_check When on -maint branches. I agree. make

Re: [libvirt] [PATCH] maint: make syntax-check default to a no-op on maint branches

2013-10-09 Thread Daniel P. Berrange
On Tue, Oct 08, 2013 at 08:45:23PM -0600, Eric Blake wrote: Maintenance branches cherry-pick some, but not all patches, and sometimes in different order, which means that 'make syntax-check' is likely to fail for hard-to-predict reasons. Yet having a common workflow makes it easier to switch

Re: [libvirt] [PATCH] maint: make syntax-check default to a no-op on maint branches

2013-10-09 Thread Eric Blake
On 10/09/2013 03:32 AM, Daniel P. Berrange wrote: On Tue, Oct 08, 2013 at 08:45:23PM -0600, Eric Blake wrote: Maintenance branches cherry-pick some, but not all patches, and sometimes in different order, which means that 'make syntax-check' is likely to fail for hard-to-predict reasons. Yet

Re: [libvirt] [PATCH] maint: make syntax-check default to a no-op on maint branches

2013-10-09 Thread Daniel P. Berrange
On Wed, Oct 09, 2013 at 06:53:00AM -0600, Eric Blake wrote: On 10/09/2013 03:32 AM, Daniel P. Berrange wrote: On Tue, Oct 08, 2013 at 08:45:23PM -0600, Eric Blake wrote: Maintenance branches cherry-pick some, but not all patches, and sometimes in different order, which means that 'make

[libvirt] [PATCH] maint: make syntax-check default to a no-op on maint branches

2013-10-08 Thread Eric Blake
Maintenance branches cherry-pick some, but not all patches, and sometimes in different order, which means that 'make syntax-check' is likely to fail for hard-to-predict reasons. Yet having a common workflow makes it easier to switch between branches. This patch sets up a filter so that 'make