Re: [libvirt] [PATCH] network: plug unininitialized read found by valgrind

2011-01-11 Thread Eric Blake
On 01/10/2011 06:54 PM, Laine Stump wrote: On 01/10/2011 05:28 PM, Eric Blake wrote: * src/util/network.c (virSocketAddrMask): Zero out port, so that iptables can initialize just the netmask, then call virSocketFormatAddr without an uninitialized read in getnameinfo. --- I'm not sure if

[libvirt] [PATCH] network: plug unininitialized read found by valgrind

2011-01-10 Thread Eric Blake
* src/util/network.c (virSocketAddrMask): Zero out port, so that iptables can initialize just the netmask, then call virSocketFormatAddr without an uninitialized read in getnameinfo. --- I'm not sure if this is the best patch; an alternative would be to call memset(network,0,sizeof network) in

Re: [libvirt] [PATCH] network: plug unininitialized read found by valgrind

2011-01-10 Thread Laine Stump
On 01/10/2011 05:28 PM, Eric Blake wrote: * src/util/network.c (virSocketAddrMask): Zero out port, so that iptables can initialize just the netmask, then call virSocketFormatAddr without an uninitialized read in getnameinfo. --- I'm not sure if this is the best patch; an alternative would be to

Re: [libvirt] [PATCH] network: plug unininitialized read found by valgrind

2011-01-10 Thread Stefan Berger
On 01/10/2011 05:28 PM, Eric Blake wrote: * src/util/network.c (virSocketAddrMask): Zero out port, so that iptables can initialize just the netmask, then call virSocketFormatAddr without an uninitialized read in getnameinfo. --- I'm not sure if this is the best patch; an alternative would be to