Re: [libvirt] [PATCH] output status information during guest shutdown again

2012-08-22 Thread Gerd v. Egidy
Hi Eric, > Beyond that, you met my comments on v1, and I didn't spot anything else, so: > > ACK and pushed. Thanks. > > This is version 2 of the patch and includes fixes as suggested by Eric > > Blake. > This last sentence can go... > > > --- > > after the ---, so that git doesn't store it in

Re: [libvirt] [PATCH] output status information during guest shutdown again

2012-08-21 Thread Eric Blake
On 08/21/2012 09:03 AM, Gerd v. Egidy wrote: > Since the move to systemd libvirt-guests doesn't output this progress > information anymore. This patch brings back this feature. > > It is helpful to show the admin what the system is waiting for and what > is left of the timeout (e.g. for calibratin

Re: [libvirt] [PATCH] output status information during guest shutdown again

2012-08-21 Thread Gerd v. Egidy
Since the move to systemd libvirt-guests doesn't output this progress information anymore. This patch brings back this feature. It is helpful to show the admin what the system is waiting for and what is left of the timeout (e.g. for calibrating the shutdown timing of a ups). Rewriting the current

Re: [libvirt] [PATCH] output status information during guest shutdown again

2012-08-21 Thread Gerd v. Egidy
Hi Eric, thanks for the in-depth review. Sorry for answering so late but I had some urgent stuff popping up here. I'll send an updated version of my patch in the next mail. > > tools/libvirt-guests.service.in | 1 + > > 2 files changed, 51 insertions(+), 15 deletions(-) > > mode change 10064

Re: [libvirt] [PATCH] output status information during guest shutdown again

2012-08-13 Thread Eric Blake
On 08/03/2012 08:52 AM, Gerd v. Egidy wrote: > With SysV-init libvirt-guests wrote status information to the console > during shutdown of the guests. > > Since the move to systemd libvirt-guests doesn't output this progress > information anymore. This patch brings back this feature. > > It is h

Re: [libvirt] [PATCH] output status information during guest shutdown again

2012-08-13 Thread Gerd v. Egidy
Hi, On Friday 03 August 2012 16:52:15 Gerd v. Egidy wrote: > With SysV-init libvirt-guests wrote status information to the console > during shutdown of the guests. > > Since the move to systemd libvirt-guests doesn't output this progress > information anymore. This patch brings back this feature.

[libvirt] [PATCH] output status information during guest shutdown again

2012-08-03 Thread Gerd v. Egidy
With SysV-init libvirt-guests wrote status information to the console during shutdown of the guests. Since the move to systemd libvirt-guests doesn't output this progress information anymore. This patch brings back this feature. It is helpful to show the admin what the system is waiting for and