Re: [libvirt] [PATCH] phyp: Adding Storage Management driver (comments fixed)

2010-06-23 Thread Eduardo Otubo
virBufferVSprintf(&buf, "-r prof --filter " "profile_names=%s -F virtual_eth_adapters," "virtual_opti_pool_id,virtual_scsi_adapters," "virtual_serial_adapters|sed -e 's/\"//g' -e " "'s/,/\\n/g'|

Re: [libvirt] [PATCH] phyp: Adding Storage Management driver (comments fixed)

2010-06-23 Thread Eric Blake
On 06/21/2010 03:37 PM, Eduardo Otubo wrote: > All the comments from the previous email from Eric Blake are now fixed. Also > fixed some styling by using indent on the whole file. Hope we can get this > patch pushed to 0.8.2. > > Any additional comments are always welcome. How hard would it be

[libvirt] [PATCH] phyp: Adding Storage Management driver (comments fixed)

2010-06-21 Thread Eduardo Otubo
All the comments from the previous email from Eric Blake are now fixed. Also fixed some styling by using indent on the whole file. Hope we can get this patch pushed to 0.8.2. Any additional comments are always welcome. []'s --- src/phyp/phyp_driver.c | 395 +++