subject:"\[libvirt\] \[PATCH\] phyp\: avoid a crash"

Re: [libvirt] [PATCH] phyp: avoid a crash

2011-05-14 Thread Matthias Bolte

2011/5/12 Eric Blake ebl...@redhat.com: This has been present since the introduction of phypAttachDevice in commit 444fd07a. * src/phyp/phyp_driver.c (phypAttachDevice): Don't dereference NULL. --- Found by clang, but the NULL dereference is very blatant. However, I'm worried that this

Re: [libvirt] [PATCH] phyp: avoid a crash

2011-05-14 Thread Eric Blake

On 05/14/2011 02:10 AM, Matthias Bolte wrote: 2011/5/12 Eric Blake ebl...@redhat.com: This has been present since the introduction of phypAttachDevice in commit 444fd07a. * src/phyp/phyp_driver.c (phypAttachDevice): Don't dereference NULL. Your patch doesn't make it worse as it already is

[libvirt] [PATCH] phyp: avoid a crash

2011-05-11 Thread Eric Blake

This has been present since the introduction of phypAttachDevice in commit 444fd07a. * src/phyp/phyp_driver.c (phypAttachDevice): Don't dereference NULL. --- Found by clang, but the NULL dereference is very blatant. However, I'm worried that this patch, while solving the NULL deref, is dead