Re: [libvirt] [PATCH] phyp: fix logic error on volume creation

2014-04-03 Thread Michal Privoznik
On 02.04.2014 01:39, Eric Blake wrote: The phyp code claims that it wants a non-zero value, but actually enforces a capacity of zero. It has been this way since commit ebc46fe in June 2010. Bummer that it has my name as the committer - I guess I should have been much more stubborn about not

Re: [libvirt] [PATCH] phyp: fix logic error on volume creation

2014-04-02 Thread Peter Krempa
On 04/02/14 01:39, Eric Blake wrote: The phyp code claims that it wants a non-zero value, but actually enforces a capacity of zero. It has been this way since commit ebc46fe in June 2010. Bummer that it has my name as the committer - I guess I should have been much more stubborn about not

Re: [libvirt] [PATCH] phyp: fix logic error on volume creation

2014-04-02 Thread Eric Blake
On 04/02/2014 03:49 AM, Peter Krempa wrote: On 04/02/14 01:39, Eric Blake wrote: The phyp code claims that it wants a non-zero value, but actually enforces a capacity of zero. It has been this way since commit ebc46fe in June 2010. Bummer that it has my name as the committer - I guess I

[libvirt] [PATCH] phyp: fix logic error on volume creation

2014-04-01 Thread Eric Blake
The phyp code claims that it wants a non-zero value, but actually enforces a capacity of zero. It has been this way since commit ebc46fe in June 2010. Bummer that it has my name as the committer - I guess I should have been much more stubborn about not blindly taking someone else's 1600-line