Re: [libvirt] [PATCH] portability: fix virNetDevSetMAC and virNetDevExists on BSD

2013-05-13 Thread Eric Blake
On 05/11/2013 09:05 AM, Roman Bogorodskiy wrote: Eric, thanks for fixing these stupid errors of mine. Do you run 'syntax-check' on your FreeBSD vm? So far, I've just been running it on Fedora. I suspect that it makes some GNU assumptions (at least maint.mk comes from gnulib, and upstream

Re: [libvirt] [PATCH] portability: fix virNetDevSetMAC and virNetDevExists on BSD

2013-05-11 Thread Roman Bogorodskiy
Eric Blake wrote: On 05/03/2013 07:35 AM, Roman Bogorodskiy wrote: - provide virNetDevSetMAC() implementation based on SIOCSIFLLADDR ioctl. - adjust virNetDevExists() to check for ENXIO error because FreeBSD throws it when device doesn't exist --- configure.ac | 8

Re: [libvirt] [PATCH] portability: fix virNetDevSetMAC and virNetDevExists on BSD

2013-05-10 Thread Eric Blake
On 05/03/2013 07:35 AM, Roman Bogorodskiy wrote: - provide virNetDevSetMAC() implementation based on SIOCSIFLLADDR ioctl. - adjust virNetDevExists() to check for ENXIO error because FreeBSD throws it when device doesn't exist --- configure.ac | 8 src/util/virnetdev.c

[libvirt] [PATCH] portability: fix virNetDevSetMAC and virNetDevExists on BSD

2013-05-03 Thread Roman Bogorodskiy
- provide virNetDevSetMAC() implementation based on SIOCSIFLLADDR ioctl. - adjust virNetDevExists() to check for ENXIO error because FreeBSD throws it when device doesn't exist --- configure.ac | 8 src/util/virnetdev.c | 41 - 2 files