Re: [libvirt] [PATCH] qemu: Add USB and memory balloon by default for aarch64/virt guests

2018-02-01 Thread Andrea Bolognani
On Thu, 2018-02-01 at 15:49 +0100, Peter Krempa wrote: > > We have VIR_DOMAIN_DEF_PARSE_ABI_UPDATE, which is only passed in > > when the guest is new - or the user has updated the XML themselves, > > in which case all bets are off when it comes to guest ABI stability > > anyway. > > Even with

Re: [libvirt] [PATCH] qemu: Add USB and memory balloon by default for aarch64/virt guests

2018-02-01 Thread Peter Krempa
On Thu, Feb 01, 2018 at 15:24:32 +0100, Andrea Bolognani wrote: > On Thu, 2018-02-01 at 13:52 +, Daniel P. Berrangé wrote: > > > Note that I'm not advocating adding controllers or any other > > > hardware to *existing* guests - that would clearly be a guest ABI > > > breakage and thus

Re: [libvirt] [PATCH] qemu: Add USB and memory balloon by default for aarch64/virt guests

2018-02-01 Thread Andrea Bolognani
On Thu, 2018-02-01 at 13:52 +, Daniel P. Berrangé wrote: > > Note that I'm not advocating adding controllers or any other > > hardware to *existing* guests - that would clearly be a guest ABI > > breakage and thus Extremely Bad™. For newly-defined guests, however, > > none of the above applies

Re: [libvirt] [PATCH] qemu: Add USB and memory balloon by default for aarch64/virt guests

2018-02-01 Thread Daniel P . Berrangé
On Thu, Feb 01, 2018 at 02:44:03PM +0100, Andrea Bolognani wrote: > On Thu, 2018-02-01 at 12:54 +, Daniel P. Berrangé wrote: > > > If an application breaks based on the USB controller being either > > > present or not present, then they shouldn't be relying on libvirt's > > > default but

Re: [libvirt] [PATCH] qemu: Add USB and memory balloon by default for aarch64/virt guests

2018-02-01 Thread Andrea Bolognani
On Thu, 2018-02-01 at 12:54 +, Daniel P. Berrangé wrote: > > If an application breaks based on the USB controller being either > > present or not present, then they shouldn't be relying on libvirt's > > default but rather explicitly opt either in or out. > > It is not merely the mgmt

Re: [libvirt] [PATCH] qemu: Add USB and memory balloon by default for aarch64/virt guests

2018-02-01 Thread Marcin Juszkiewicz
W dniu 01.02.2018 o 13:54, Daniel P. Berrangé pisze: > So I stil consider this change to be something we should not do. As a person who started whole discussion I fully agree. > It is easy to fix Nova to setup USB if it desires it, so there's no > blocking item that requires us to do this in

Re: [libvirt] [PATCH] qemu: Add USB and memory balloon by default for aarch64/virt guests

2018-02-01 Thread Daniel P . Berrangé
On Mon, Jan 29, 2018 at 01:04:33PM +0100, Andrea Bolognani wrote: > On Thu, 2018-01-25 at 16:58 +, Daniel P. Berrangé wrote: > > On Thu, Jan 25, 2018 at 05:45:51PM +0100, Andrea Bolognani wrote: > > > Basically all existing guest types, regardless of the architectur, > > > get both a USB

Re: [libvirt] [PATCH] qemu: Add USB and memory balloon by default for aarch64/virt guests

2018-01-31 Thread Andrea Bolognani
[re-added danpb to CC] On Tue, 2018-01-30 at 22:48 +0100, Marcin Juszkiewicz wrote: > W dniu 29.01.2018 o 13:04, Andrea Bolognani pisze: > > > This doesn't really help nova in practice, because it needs to operate > > > correctly with pre-existing libbvirt releases, and even on x86 it should > >

Re: [libvirt] [PATCH] qemu: Add USB and memory balloon by default for aarch64/virt guests

2018-01-30 Thread Marcin Juszkiewicz
W dniu 29.01.2018 o 13:04, Andrea Bolognani pisze: >> This doesn't really help nova in practice, because it needs to operate >> correctly with pre-existing libbvirt releases, and even on x86 it should >> not be relying on the default USB1 controller, but rather adding a USB2 >> or USB3 controller.

Re: [libvirt] [PATCH] qemu: Add USB and memory balloon by default for aarch64/virt guests

2018-01-29 Thread Andrea Bolognani
On Thu, 2018-01-25 at 16:58 +, Daniel P. Berrangé wrote: > On Thu, Jan 25, 2018 at 05:45:51PM +0100, Andrea Bolognani wrote: > > Basically all existing guest types, regardless of the architectur, > > get both a USB controller and a virtio memory balloon by default. > > > > s390 guests are an

Re: [libvirt] [PATCH] qemu: Add USB and memory balloon by default for aarch64/virt guests

2018-01-25 Thread Daniel P . Berrangé
On Thu, Jan 25, 2018 at 05:45:51PM +0100, Andrea Bolognani wrote: > Basically all existing guest types, regardless of the architectur, > get both a USB controller and a virtio memory balloon by default. > > s390 guests are an exception, for the very good reason that they > don't support USB at

[libvirt] [PATCH] qemu: Add USB and memory balloon by default for aarch64/virt guests

2018-01-25 Thread Andrea Bolognani
Basically all existing guest types, regardless of the architectur, get both a USB controller and a virtio memory balloon by default. s390 guests are an exception, for the very good reason that they don't support USB at all; the other exception is aarch64/virt guests, but in the latter case isn't