Re: [libvirt] [PATCH] qemu: Add support for changing timeout value to open unix monitor socket

2014-01-10 Thread Daniel P. Berrange
On Mon, Dec 30, 2013 at 07:23:00PM +0200, Pavel Fux wrote: > Hi, > > I am talking about *Bug > 987088*, > I have added a patch and a description of the fix, this is a copy of my > comment on the bug: > > the default code behavior is wait for 3 s

[libvirt] [PATCH] qemu: Add support for changing timeout value to open unix monitor socket

2014-01-02 Thread Pavel Fux
I have fixed all comments except: "We prefer passing the driver as an argument instead". I thought of it at first but I looked at the function call graph and it's not that easy. and you did the same in src/qemu/qemu_process.c:115 -- libvir-list mailing list libvir-list@redhat.com https://www.red

Re: [libvirt] [PATCH] qemu: Add support for changing timeout value to open unix monitor socket

2014-01-02 Thread Martin Kletzander
On Mon, Dec 30, 2013 at 07:23:00PM +0200, Pavel Fux wrote: > Hi, > > I am talking about *Bug > 987088*, > I have added a patch and a description of the fix, this is a copy of my > comment on the bug: > > the default code behavior is wait for 3 s

[libvirt] [PATCH] qemu: Add support for changing timeout value to open unix monitor socket

2013-12-30 Thread Pavel Fux
Hi, I am talking about *Bug 987088*, I have added a patch and a description of the fix, this is a copy of my comment on the bug: the default code behavior is wait for 3 seconds and if the socket is not opened yet, print this error and terminate.