[libvirt] [PATCH] qemu: Avoid overflow when setting migration speed on inactive domains

2014-04-25 Thread Jiri Denemark
Commit c4206d7 fixed the overflow for running domains. However, we need a similar check when setting migration speed on inactive domains. At first look, it may seem the check in c4206d7 is now redundant but qemuDomainMigrateSetMaxSpeed is not the only caller of qemuMonitorSetMigrationSpeed so we

Re: [libvirt] [PATCH] qemu: Avoid overflow when setting migration speed on inactive domains

2014-04-25 Thread Eric Blake
On 04/25/2014 08:04 AM, Jiri Denemark wrote: Commit c4206d7 fixed the overflow for running domains. However, we need a similar check when setting migration speed on inactive domains. At first look, it may seem the check in c4206d7 is now redundant but qemuDomainMigrateSetMaxSpeed is not the

Re: [libvirt] [PATCH] qemu: Avoid overflow when setting migration speed on inactive domains

2014-04-25 Thread Jiri Denemark
On Fri, Apr 25, 2014 at 08:09:10 -0600, Eric Blake wrote: On 04/25/2014 08:04 AM, Jiri Denemark wrote: Commit c4206d7 fixed the overflow for running domains. However, we need a similar check when setting migration speed on inactive domains. At first look, it may seem the check in c4206d7

Re: [libvirt] [PATCH] qemu: Avoid overflow when setting migration speed

2014-04-14 Thread Jiri Denemark
On Fri, Apr 11, 2014 at 08:31:51 -0600, Eric Blake wrote: On 04/11/2014 04:52 AM, Jiri Denemark wrote: When passing migration bandwidth to QEMU, we multiply it by 1024 * 1024 to convert the speed to B/s and the result still needs to fit in int64_t.

[libvirt] [PATCH] qemu: Avoid overflow when setting migration speed

2014-04-11 Thread Jiri Denemark
When passing migration bandwidth to QEMU, we multiply it by 1024 * 1024 to convert the speed to B/s and the result still needs to fit in int64_t. https://bugzilla.redhat.com/show_bug.cgi?id=1083483 Signed-off-by: Jiri Denemark jdene...@redhat.com --- src/qemu/qemu_monitor.c | 7 +++ 1 file

Re: [libvirt] [PATCH] qemu: Avoid overflow when setting migration speed

2014-04-11 Thread Eric Blake
On 04/11/2014 04:52 AM, Jiri Denemark wrote: When passing migration bandwidth to QEMU, we multiply it by 1024 * 1024 to convert the speed to B/s and the result still needs to fit in int64_t. https://bugzilla.redhat.com/show_bug.cgi?id=1083483 Signed-off-by: Jiri Denemark