Re: [libvirt] [PATCH] qemu: Do not override config XML in case of snapshot revert

2019-05-15 Thread Daniel Henrique Barboza
On 5/15/19 3:17 PM, Eric Blake wrote: On 5/15/19 1:03 PM, Daniel Henrique Barboza wrote: On 5/15/19 12:49 PM, Eric Blake wrote: If you reboot the guest, the inactive XML will become active and the guest will have a new device. But if the guest continues running without rebooting, the

Re: [libvirt] [PATCH] qemu: Do not override config XML in case of snapshot revert

2019-05-15 Thread Eric Blake
On 5/15/19 1:03 PM, Daniel Henrique Barboza wrote: > > > On 5/15/19 12:49 PM, Eric Blake wrote: >> If you reboot the guest, the inactive XML will become active and the >> guest will have a new device. But if the guest continues running without >> rebooting, the inactive XML will be different

Re: [libvirt] [PATCH] qemu: Do not override config XML in case of snapshot revert

2019-05-15 Thread Daniel Henrique Barboza
On 5/15/19 12:49 PM, Eric Blake wrote: If you reboot the guest, the inactive XML will become active and the guest will have a new device. But if the guest continues running without rebooting, the inactive XML will be different from the live XML. Whether or not the guest rebooted, a revert must

Re: [libvirt] [PATCH] qemu: Do not override config XML in case of snapshot revert

2019-05-15 Thread Eric Blake
On 5/15/19 10:22 AM, Maxiwell S. Garcia wrote: > On Tue, May 14, 2019 at 09:38:12AM -0500, Eric Blake wrote: >> On 5/14/19 8:37 AM, Michal Privoznik wrote: >>> On 5/13/19 8:48 PM, Daniel Henrique Barboza wrote: Tried to reproduce the error using my x86 laptop but got hit by

Re: [libvirt] [PATCH] qemu: Do not override config XML in case of snapshot revert

2019-05-15 Thread Maxiwell S. Garcia
On Tue, May 14, 2019 at 09:38:12AM -0500, Eric Blake wrote: > On 5/14/19 8:37 AM, Michal Privoznik wrote: > > On 5/13/19 8:48 PM, Daniel Henrique Barboza wrote: > >> Tried to reproduce the error using my x86 laptop but got hit by > >> https://bugzilla.redhat.com/show_bug.cgi?id=1689216 when trying

Re: [libvirt] [PATCH] qemu: Do not override config XML in case of snapshot revert

2019-05-15 Thread Maxiwell S. Garcia
On Tue, May 14, 2019 at 03:37:26PM +0200, Michal Privoznik wrote: > On 5/13/19 8:48 PM, Daniel Henrique Barboza wrote: > > Tried to reproduce the error using my x86 laptop but got hit by > > https://bugzilla.redhat.com/show_bug.cgi?id=1689216 when trying > > to create the snapshot using upstream

Re: [libvirt] [PATCH] qemu: Do not override config XML in case of snapshot revert

2019-05-14 Thread Eric Blake
On 5/14/19 8:37 AM, Michal Privoznik wrote: > On 5/13/19 8:48 PM, Daniel Henrique Barboza wrote: >> Tried to reproduce the error using my x86 laptop but got hit by >> https://bugzilla.redhat.com/show_bug.cgi?id=1689216 when trying >> to create the snapshot using upstream code: >> > > Actually, I

Re: [libvirt] [PATCH] qemu: Do not override config XML in case of snapshot revert

2019-05-14 Thread Michal Privoznik
On 5/13/19 8:48 PM, Daniel Henrique Barboza wrote: Tried to reproduce the error using my x86 laptop but got hit by https://bugzilla.redhat.com/show_bug.cgi?id=1689216 when trying to create the snapshot using upstream code: $ sudo ./run tools/virsh snapshot-create-as ub1810-cpu-hotplug snap

Re: [libvirt] [PATCH] qemu: Do not override config XML in case of snapshot revert

2019-05-13 Thread Daniel Henrique Barboza
Tried to reproduce the error using my x86 laptop but got hit by https://bugzilla.redhat.com/show_bug.cgi?id=1689216 when trying to create the snapshot using upstream code: $ sudo ./run tools/virsh snapshot-create-as ub1810-cpu-hotplug snap error: operation failed: Failed to take snapshot: Error:

[libvirt] [PATCH] qemu: Do not override config XML in case of snapshot revert

2019-04-30 Thread Maxiwell S. Garcia
Snapshot create operation saves the live XML and uses it to replace the domain definition in case of revert. But the VM config XML is not saved and the revert operation does not address this issue. This commit prevents the config XML from being overridden by snapshot definition. An active domain