Re: [libvirt] [PATCH] qemu: Don't access uninitialized memory

2016-03-19 Thread Erik Skultety
On 16/03/16 10:48, Martin Kletzander wrote: > Very early ping, I know, but it's almost trivial and it fixes a crash > when running domxml-to-native. > > On Fri, Mar 11, 2016 at 02:25:16PM +0100, Martin Kletzander wrote: >> In qemuConnectDomainXMLToNative() we set up the monitor, but we never >>

Re: [libvirt] [PATCH] qemu: Don't access uninitialized memory

2016-03-16 Thread Martin Kletzander
Very early ping, I know, but it's almost trivial and it fixes a crash when running domxml-to-native. On Fri, Mar 11, 2016 at 02:25:16PM +0100, Martin Kletzander wrote: In qemuConnectDomainXMLToNative() we set up the monitor, but we never memset() it to zeros. Thanks to the introduction of the

[libvirt] [PATCH] qemu: Don't access uninitialized memory

2016-03-11 Thread Martin Kletzander
In qemuConnectDomainXMLToNative() we set up the monitor, but we never memset() it to zeros. Thanks to the introduction of the logfile parameter of chardevs (and the logfile member of the struct), we started checking whether that's non-NULL and that exposed this old error. Signed-off-by: Martin