Re: [libvirt] [PATCH] qemu: Don't initialize struct utsname

2018-01-22 Thread Daniel P. Berrange
On Mon, Jan 22, 2018 at 03:12:46PM +0100, Jiri Denemark wrote: > On Mon, Jan 22, 2018 at 14:01:26 +, Daniel P. Berrange wrote: > > On Mon, Jan 22, 2018 at 02:54:42PM +0100, Jiri Denemark wrote: > > > It breaks the build and it is not really useful for anything. > > > > Why does that break the

Re: [libvirt] [PATCH] qemu: Don't initialize struct utsname

2018-01-22 Thread Jiri Denemark
On Mon, Jan 22, 2018 at 14:01:26 +, Daniel P. Berrange wrote: > On Mon, Jan 22, 2018 at 02:54:42PM +0100, Jiri Denemark wrote: > > It breaks the build and it is not really useful for anything. > > Why does that break the build ? "{ 0 }" is a valid initializer for > any struct according to

Re: [libvirt] [PATCH] qemu: Don't initialize struct utsname

2018-01-22 Thread Daniel P. Berrange
On Mon, Jan 22, 2018 at 02:54:42PM +0100, Jiri Denemark wrote: > It breaks the build and it is not really useful for anything. Why does that break the build ? "{ 0 }" is a valid initializer for any struct according to the C standards. > > Signed-off-by: Jiri Denemark >

[libvirt] [PATCH] qemu: Don't initialize struct utsname

2018-01-22 Thread Jiri Denemark
It breaks the build and it is not really useful for anything. Signed-off-by: Jiri Denemark --- Pushed under the build breaker rule. src/qemu/qemu_capabilities.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_capabilities.c