Re: [libvirt] [PATCH] qemu: Don't jump to endjob if no job was even started

2012-02-01 Thread Michal Privoznik
On 31.01.2012 18:22, Laine Stump wrote: On 01/31/2012 11:16 AM, Michal Privoznik wrote: In qemuDomainShutdownFlags if we try to use guest agent, which has error or is not configured, we jump go endjob label even if we haven't started any job yet. This may lead to the daemon crash: 1) virsh

[libvirt] [PATCH] qemu: Don't jump to endjob if no job was even started

2012-01-31 Thread Michal Privoznik
In qemuDomainShutdownFlags if we try to use guest agent, which has error or is not configured, we jump go endjob label even if we haven't started any job yet. This may lead to the daemon crash: 1) virsh shutdown --mode agent on a domain without agent configured 2) wait until domain quits 3) virsh

Re: [libvirt] [PATCH] qemu: Don't jump to endjob if no job was even started

2012-01-31 Thread Laine Stump
On 01/31/2012 11:16 AM, Michal Privoznik wrote: In qemuDomainShutdownFlags if we try to use guest agent, which has error or is not configured, we jump go endjob label even if we haven't started any job yet. This may lead to the daemon crash: 1) virsh shutdown --mode agent on a domain without