Re: [libvirt] [PATCH] qemu: Error prompt if invalid dump image format specified

2011-01-17 Thread Osier Yang
于 2011年01月17日 22:41, Eric Blake 写道: > On 01/16/2011 09:39 PM, Osier Yang wrote: >> "getCompressionType" trys to throw error when invalid dump image >> format is specified, or the compression program for the specified >> image format is not available, but at the same time, it returns >> enum qemud_s

Re: [libvirt] [PATCH] qemu: Error prompt if invalid dump image format specified

2011-01-17 Thread Eric Blake
On 01/16/2011 09:39 PM, Osier Yang wrote: > "getCompressionType" trys to throw error when invalid dump image > format is specified, or the compression program for the specified > image format is not available, but at the same time, it returns > enum qemud_save_formats, as a result, upper function w

Re: [libvirt] [PATCH] qemu: Error prompt if invalid dump image format specified

2011-01-17 Thread Daniel P. Berrange
On Mon, Jan 17, 2011 at 12:39:21PM +0800, Osier Yang wrote: > "getCompressionType" trys to throw error when invalid dump image > format is specified, or the compression program for the specified > image format is not available, but at the same time, it returns > enum qemud_save_formats, as a result

[libvirt] [PATCH] qemu: Error prompt if invalid dump image format specified

2011-01-16 Thread Osier Yang
"getCompressionType" trys to throw error when invalid dump image format is specified, or the compression program for the specified image format is not available, but at the same time, it returns enum qemud_save_formats, as a result, upper function will think it was successful, and disgard to check