Re: [libvirt] [PATCH] qemu: Exit on first error in qemuDomainGetMemoryParameters

2010-10-20 Thread Matthias Bolte
2010/10/20 Daniel Veillard : > On Wed, Oct 20, 2010 at 02:37:53PM +0200, Matthias Bolte wrote: >> There is no point in trying to fill params beyond the first error, >> because when qemuDomainGetMemoryParameters returns -1 then the caller >> cannot detect which values in params are valid. >> --- > >

Re: [libvirt] [PATCH] qemu: Exit on first error in qemuDomainGetMemoryParameters

2010-10-20 Thread Daniel Veillard
On Wed, Oct 20, 2010 at 02:37:53PM +0200, Matthias Bolte wrote: > There is no point in trying to fill params beyond the first error, > because when qemuDomainGetMemoryParameters returns -1 then the caller > cannot detect which values in params are valid. > --- Okay ACK > There is a similar patt

[libvirt] [PATCH] qemu: Exit on first error in qemuDomainGetMemoryParameters

2010-10-20 Thread Matthias Bolte
There is no point in trying to fill params beyond the first error, because when qemuDomainGetMemoryParameters returns -1 then the caller cannot detect which values in params are valid. --- There is a similar pattern in qemuDomainSetMemoryParameters that tries to apply all given params even if one