Re: [libvirt] [PATCH] qemu: Fix FD leak in qemudStartVMDaemon

2010-03-18 Thread Daniel Veillard
On Wed, Mar 17, 2010 at 10:35:51PM +0100, Matthias Bolte wrote: The logfile FD is dup2'ed in __virExec in the child. The FD needs to be closed in the parent, otherwise it leaks. --- src/qemu/qemu_driver.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git

Re: [libvirt] [PATCH] qemu: Fix FD leak in qemudStartVMDaemon

2010-03-18 Thread Matthias Bolte
2010/3/18 Daniel Veillard veill...@redhat.com: On Wed, Mar 17, 2010 at 10:35:51PM +0100, Matthias Bolte wrote: The logfile FD is dup2'ed in __virExec in the child. The FD needs to be closed in the parent, otherwise it leaks. ---  src/qemu/qemu_driver.c |    3 +++  1 files changed, 3

Re: [libvirt] [PATCH] qemu: Fix FD leak in qemudStartVMDaemon

2010-03-18 Thread Daniel Veillard
On Thu, Mar 18, 2010 at 02:31:56PM +0100, Matthias Bolte wrote: 2010/3/18 Daniel Veillard veill...@redhat.com: On Wed, Mar 17, 2010 at 10:35:51PM +0100, Matthias Bolte wrote: The logfile FD is dup2'ed in __virExec in the child. The FD needs to be closed in the parent, otherwise it leaks.

Re: [libvirt] [PATCH] qemu: Fix FD leak in qemudStartVMDaemon

2010-03-18 Thread Matthias Bolte
2010/3/18 Daniel Veillard veill...@redhat.com: On Thu, Mar 18, 2010 at 02:31:56PM +0100, Matthias Bolte wrote: 2010/3/18 Daniel Veillard veill...@redhat.com: On Wed, Mar 17, 2010 at 10:35:51PM +0100, Matthias Bolte wrote: The logfile FD is dup2'ed in __virExec in the child. The FD needs to

[libvirt] [PATCH] qemu: Fix FD leak in qemudStartVMDaemon

2010-03-17 Thread Matthias Bolte
The logfile FD is dup2'ed in __virExec in the child. The FD needs to be closed in the parent, otherwise it leaks. --- src/qemu/qemu_driver.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index c8f3a15..fbb1275 100644 ---